Fix omniauth-oauth2 1.4 callback_url regression #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def callback_url | ||
| full_host + script_name + callback_path | ||
| end | ||
|
|
Bug introduced by omniauth-oauth2 change: omniauth/omniauth-oauth2#70 Fixes WebTheoryLLC#3
jtokoph
force-pushed
the
jtokoph-patch-1
branch
from
77c2bc4
to
3032f76
Compare
jcgertig
added a commit
that referenced
this pull request
Feb 23, 2016
Fix omniauth-oauth2 1.4 callback_url regression
pjg
added a commit
to Hello-bar/omniauth-createsend
that referenced
this pull request
Jun 21, 2017
pjg
added a commit
to Hello-bar/omniauth-drip
that referenced
this pull request
Jul 3, 2017
pjg
added a commit
to Hello-bar/omniauth-verticalresponse
that referenced
this pull request
Jul 27, 2017
webgago
added a commit
to Hello-bar/omniauth-infusionsoft
that referenced
this pull request
Sep 5, 2017
pjg
added a commit
to Hello-bar/omniauth-constantcontact2
that referenced
this pull request
Oct 6, 2017
l1h3r
pushed a commit
to l1h3r/omniauth-infusionsoft
that referenced
this pull request
Mar 16, 2018
* Fix compatibility with omniauth-oauth 1.4+ References: * omniauth/omniauth-oauth2#70 * omniauth/omniauth-oauth2@2615267 * omniauth/omniauth-oauth2#82 * jdennes/omniauth-createsend#3 * WebTheoryLLC/omniauth-twitch#4 * jdennes/omniauth-createsend#5 * DripEmail/omniauth-drip#6 * Don't force https if it's localhost * Allow 127.0.0.1 and localhost to be on http * Lookup IP for the given host and force ssl Avoid to force ssl for local IPs (127/8 network) * Improve resolving * Improve even more * Fix regexp * Allow fe80::* entirely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced by omniauth-oauth2 change: omniauth/omniauth-oauth2#70
Fixes #3