Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with omniauth-oauth2 v1.4+ #5

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Fix compatibility with omniauth-oauth2 v1.4+ #5

merged 1 commit into from
Apr 22, 2020

Conversation

pjg
Copy link
Contributor

@pjg pjg commented Jun 21, 2017

@pjg
Copy link
Contributor Author

pjg commented Jun 21, 2017

Without this fix, this gem is incompatible with the latest omniauth-oauth2 gem. And the issue is very hard to debug.

@pjg pjg mentioned this pull request Jul 3, 2017
Merged
pjg added a commit to Hello-bar/omniauth-verticalresponse that referenced this pull request Jul 27, 2017
@pjg
Fix compatibility with omniauth-oauth 1.4+
416e1a6 
References:
* omniauth/omniauth-oauth2#70
* omniauth/omniauth-oauth2@2615267
* omniauth/omniauth-oauth2#82
* jdennes/omniauth-createsend#3
* WebTheoryLLC/omniauth-twitch#4
* jdennes/omniauth-createsend#5
* DripEmail/omniauth-drip#6
@pjg pjg mentioned this pull request Jul 27, 2017
Open
webgago added a commit to Hello-bar/omniauth-infusionsoft that referenced this pull request Sep 5, 2017
@webgago
Fix compatibility with omniauth-oauth 1.4+
05fdfeb 
References:
* omniauth/omniauth-oauth2#70
* omniauth/omniauth-oauth2@2615267
* omniauth/omniauth-oauth2#82
* jdennes/omniauth-createsend#3
* WebTheoryLLC/omniauth-twitch#4
* jdennes/omniauth-createsend#5
* DripEmail/omniauth-drip#6
@webgago webgago mentioned this pull request Sep 6, 2017
Merged
pjg added a commit to Hello-bar/omniauth-constantcontact2 that referenced this pull request Oct 6, 2017
@pjg
Fix compatibility with omniauth-oauth 1.4+
ba98609 
References:
* omniauth/omniauth-oauth2#70
* omniauth/omniauth-oauth2@2615267
* omniauth/omniauth-oauth2#82
* jdennes/omniauth-createsend#3
* WebTheoryLLC/omniauth-twitch#4
* jdennes/omniauth-createsend#5
* DripEmail/omniauth-drip#6
* Kosmin/omniauth-verticalresponse#3
@pjg pjg mentioned this pull request Oct 6, 2017
Open
l1h3r pushed a commit to l1h3r/omniauth-infusionsoft that referenced this pull request Mar 16, 2018
@webgago @l1h3r
Fix compatibility with omniauth-oauth 1.4+ and allow http locally (#4)
d4be6d0 
* Fix compatibility with omniauth-oauth 1.4+

References:
* omniauth/omniauth-oauth2#70
* omniauth/omniauth-oauth2@2615267
* omniauth/omniauth-oauth2#82
* jdennes/omniauth-createsend#3
* WebTheoryLLC/omniauth-twitch#4
* jdennes/omniauth-createsend#5
* DripEmail/omniauth-drip#6

* Don't force https if it's localhost

* Allow 127.0.0.1 and localhost to be on http

* Lookup IP for the given host and force ssl

Avoid to force ssl for local IPs (127/8 network)

* Improve resolving

* Improve even more

* Fix regexp

* Allow fe80::* entirely
@espen espen mentioned this pull request Apr 22, 2020
Closed
jdennes
jdennes approved these changes Apr 22, 2020
View reviewed changes
Copy link
Owner

@jdennes jdennes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Sorry that I missed this when it was opened.

@jdennes jdennes merged commit 7c3bf1f into jdennes:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdennes jdennes jdennes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

callback url does not work proberly
2 participants
@pjg @jdennes