Inline visualizers in custom data inspectors #1966
Open
+75
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aims at making inline visualizers work on the data inspector so that more rgb encodings can be added as custom pattern language inspector rows. This was never setup to work because the inline visualizer rendering function was a private member function. In order to be accessible from the inspector class the rendering function was made public. Missing still is the tooltip to make it behave like other color entries.
WerWolv
requested changes
Nov 24, 2024
| auto displayFunction = [value = pattern->getFormattedValue()] { | ||
| ImGui::TextUnformatted(value.c_str()); | ||
| auto displayFunction = [pattern,value = pattern->getFormattedValue()] { | ||
| auto drawer = std::make_unique<hex::ui::PatternDrawer>(); |
There was a problem hiding this comment.
This causes a lot of unnecessary allocations every single frame. Instead, I believe the PatternDrawer shouldn't be involved at all in rendering this
There was a problem hiding this comment.
The only function that draws the inline visualizer is defined as a member function of pattern drawer. Do we need to create an identical function here as well?
…tor. The previous version was trying to use the drawVisualizer function in PatternDrawer from DataInspector which was inefficient. The former drawVisualizer code was put in its own class in ui from imhex plugin library. Both DataInspector and PatternDrawer get a member field that is used to draw inline and regular visualizers. Code has been tested to make sure it works for both the inspector and the pattern drawer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
This PR aims at making inline visualizers work on the data inspector so that more rgb encodings can be added as custom pattern language inspector rows. This was never setup to work because the inline visualizer rendering function was a private member function.
Implementation description
In order to be accessible from the inspector class the rendering function was made public.
Additional things
Missing still is the tooltip to make it behave like other color entries.