Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline visualizers in custom data inspectors #1966

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Nov 23, 2024

  1. Inline visualizers in custom data inspectors

    This PR aims at making inline visualizers work on the data inspector so that more rgb encodings can be added as custom pattern language inspector rows. This was never setup to work because the inline visualizer rendering function was a private member function.
    
    In order to be accessible from the inspector class the rendering function was made public.
    
    Missing still is the tooltip to make it behave like other color entries.
    paxcut committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    b860bf1 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2024

  1. Configuration menu
    Copy the full SHA
    e8954a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bfdc8fb View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. A better implementation for the inline visualizers in the data inspec…

    …tor.
    
    The previous version was trying to use the drawVisualizer function in PatternDrawer from DataInspector which was inefficient. The former drawVisualizer code was put in its own class in ui from imhex plugin library. Both DataInspector and PatternDrawer get a member field that is used to draw inline and regular visualizers. Code has been tested to make sure it works for both the inspector and the pattern drawer.
    paxcut committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    dd8703e View commit details
    Browse the repository at this point in the history