Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Globalfee #142

Closed
wants to merge 118 commits into from
Closed

v4: Globalfee #142

wants to merge 118 commits into from

Conversation

faddat
Copy link
Collaborator

@faddat faddat commented Apr 11, 2023

Description and Motivation

x/globalfee from the cosmos hub, upgraded to use cosmos-sdk v0.47.x

This PR is incomplete, and at minimum will need fairly extensive changes to tests.

Related Issues

#138


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly golangci-lint run ./... --fix.

faddat and others added 30 commits March 19, 2023 00:15
fix: remove redundant init genesis call
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.6.1 to 1.7.0.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.6.1...v1.7.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.46.11 to 0.47.1.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.47.1/CHANGELOG.md)
- [Commits](cosmos/cosmos-sdk@v0.46.11...v0.47.1)

---
updated-dependencies:
- dependency-name: github.com/cosmos/cosmos-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…modules/github.com/cosmos/cosmos-sdk-0.47.1

build(deps): bump github.com/cosmos/cosmos-sdk from 0.46.11 to 0.47.1
…modules/github.com/spf13/cobra-1.7.0

build(deps): bump github.com/spf13/cobra from 1.6.1 to 1.7.0
sontrinh16 and others added 3 commits May 25, 2023 15:24
add globalfee to ante handler (sht todo with how sdk 47 treat subspace and module store)
dependabot bot and others added 2 commits May 26, 2023 10:06
Bumps [github.com/cosmos/ibc-go/v7](https://github.com/cosmos/ibc-go) from 7.0.0 to 7.0.1.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/main/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v7.0.0...v7.0.1)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v7
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…modules/github.com/cosmos/ibc-go/v7-7.0.1

build(deps): bump github.com/cosmos/ibc-go/v7 from 7.0.0 to 7.0.1
@faddat
Copy link
Collaborator Author

faddat commented May 27, 2023

@hoangdv2429 @sontrinh16 @pysel we should also upgrade x/globalfee to make sure it exactly matches gaia's for better maintainability.

@faddat faddat changed the title Globalfee v17: Globalfee May 27, 2023
@faddat faddat changed the title v17: Globalfee v4: Globalfee May 27, 2023
@faddat faddat mentioned this pull request May 27, 2023
faddat and others added 16 commits May 27, 2023 10:47
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.3 to 1.8.4.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.3...v1.8.4)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…modules/github.com/stretchr/testify-1.8.4

build(deps): bump github.com/stretchr/testify from 1.8.3 to 1.8.4
Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.15.0 to 1.16.0.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](spf13/viper@v1.15.0...v1.16.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/viper
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…modules/github.com/spf13/viper-1.16.0

build(deps): bump github.com/spf13/viper from 1.15.0 to 1.16.0
Invalid memory address or nil pointer dereference when collect-gentxs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.