Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor error in typings for Polyhedron #315

Closed
2 of 6 tasks
TimLuq opened this issue Sep 3, 2017 · 0 comments
Closed
2 of 6 tasks

Minor error in typings for Polyhedron #315

TimLuq opened this issue Sep 3, 2017 · 0 comments

Comments

@TimLuq
Copy link
Contributor

TimLuq commented Sep 3, 2017 •
edited
Loading

A minor error in typings causes build of projects using the typings to fail.

The offending typings are a forced return type of the Polyhedron constructor which is forbidden. Expect PR soon.

I'll leave a reference to issue #297 as well.

Version:
  • v2.x.x
  • v1.x.x
Issue type:
  • Bug
  • Proposal/Enhancement
  • Question
  • Discussion
Tested on:

TypeScript 2.5.2
@TimLuq TimLuq mentioned this issue Sep 3, 2017
Merged
sasha240100 added a commit that referenced this issue Sep 3, 2017
@sasha240100
Merge pull request #316 from TimLuq/#315
46967f9 
Fixes #315 - remove constructor return type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TimLuq