Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #315 - remove constructor return type #316

Merged
merged 1 commit into from
Sep 3, 2017
Merged

Fixes #315 - remove constructor return type #316

merged 1 commit into from
Sep 3, 2017

Conversation

TimLuq
Copy link
Contributor

@TimLuq TimLuq commented Sep 3, 2017

See issue #315.

The forbidden return type on the constructor is removed.

hirako2000
hirako2000 approved these changes Sep 3, 2017
View reviewed changes
Copy link
Collaborator

@hirako2000 hirako2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton, I haven't gotten a chance to verify all the types I recently added.
I suspect a similar mistake is made elsewhere (by me).
Cheers for spotting this and for your contribution!

@sasha240100 sasha240100 merged commit 46967f9 into WhitestormJS:dev Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirako2000 hirako2000 hirako2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimLuq @hirako2000 @sasha240100