Spotlight shadows #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang (on OSX) issues a warning at the TopicManager.
```
error: loop variable 'liter' of type 'const boost::shared_ptr<gazebo::transport::Node>' creates a copy from type 'const boost::shared_ptr<gazebo::transport::Node>'
for (const auto liter : iter2.second)
^
note: use reference type 'const boost::shared_ptr<gazebo::transport::Node> &' to prevent copying
for (const auto liter : iter2.second)
^~~~~~~~~~~~~~~~~~
&
```
As proposed, using it as a reference silences the warning.
Fix typo
* Add nullptr guard in TopicManager PubToSub * Add regression test for 2875 Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
…im#2991) * Add error message to RT shader * Improve error message for loading worlds/empty.world Signed-off-by: Audrow Nash <audrow@hey.com>
* Do not force STATIC build of gtest * Need pthread on *NIX * Keep using STATIC for gtest on Windows Co-authored-by: Steve Peters <scpeters@openrobotics.org> * Add plugin dependencies for INTEGRATION_plugin * Add missing changelog entries from 11.5.0 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This potentially resolves a rarely occuring issue in long-running runs of gzserver. The uninitialized value was found by running Gazebo in Valgrind. Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>>
* LensFlare: add API to set compositor name This can be used to set the pixel format of textures for example. * LensFlarePrivate: move data members Ensure the ConnectionPtr and SubscriberPtr are last. * Distortion: read compositor name from SDF param Read the compositor name from a custom element <ignition:compositor />. Signed-off-by: Steve Peters <scpeters@openrobotics.org> * Add additional distortion and lens flare compositors * Create test world * Add test for set compositor names Signed-off-by: Audrow Nash <audrow@hey.com> * JointInspector_TEST: use QCOMPARE * JointInspector_TEST: expect more fields This has been broken since we added the expressed_in field to joint.proto Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
…orward port of gazebosim#3016) (gazebosim#3017) * Check for SDF files containing sibling elements with the same name (Forward port of gazebosim#3019) * Implement logic to handle 1.6 sibling elements
* Update changelog * Version 11.6.0
…ions (gazebosim#3009) This fixes distortion behavior when the SDFormat <ignition:legacy_mode> parameter is set to false in the distortion context. The fix ensures that pixel coordinates projected to camera plane for distortion and disables cropping. This also fixes a wraparound issue for extreme distortions. Signed-off-by: Audrow Nash <audrow@hey.com> Co-authored-by: kbjeppes <kaden.b.jeppesen@nasa.gov> Co-authored-by: Audrow Nash <audrow@hey.com>
* Make an IMPORTED target for CURL on bionic * CURL is a PRIVATE dep Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Remove unneeded CURL include, linkage * Link to CURL for two plugins only Only StaticMapPlugin and RestWebPlugin use CURL, so only add linking for these. Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
* Fixed incorrect distortion when loading scene with multiple distortion cameras Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Add models and world to show distortion bug There is a bug in the initialization of cameras with distortion. Loading multiple cameras with different distortion parameters at the same time causes some of the same distortion parameters to be applied to all those cameras. Spawning a model with a single distorted camera afterwards works fine, even in a world that already contains distorted cameras. Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
…2979) This avoids ambiguity in the presence of a top-level namespace named util, e.g. https://godbolt.org/z/WMfseEGPf. Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.