Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom shadow caster materials #5

Closed
wants to merge 13 commits into from
Closed

Custom shadow caster materials #5

wants to merge 13 commits into from

Conversation

WilliamLewww
Copy link
Owner

@WilliamLewww WilliamLewww commented Jul 8, 2021 •
edited
Loading

I added a new SDF parameter <shadow_caster_material_name> to specify what shadow caster material should be used to render shadows. The SDF is added to the scene:

<scene>
  <ignition:shadow_caster_material_name>Gazebo/shadow_caster_ignore_heightmap</ignition:shadow_caster_material_name>
  <background>0.0 0.0 0.0 1</background>
</scene>

Currently, the scene is hardcoded to use "Gazebo/shadow_caster" for all shadow caster materials.

@WilliamLewww
Ignore shadows generated from directional light
05a9c24 
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@WilliamLewww
Added world matrix comparison to remove heightmap self-shadows
f951b00 
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@WilliamLewww
Removed position printout for directional light
618f610 
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@WilliamLewww
Added shadow caster param to scene SDF
5e38c26
@WilliamLewww
Added shadow caster material name to RTShaderSystem
686bc8e 
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@WilliamLewww
Added new shadow caster program that ignores heightmap
beab59b 
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@WilliamLewww
Merge pull request #4 from WilliamLewww/wlew/spotlight_shadows
d26e221 
Spotlight shadows
@WilliamLewww
Merge branch 'osrf:gazebo11' into wlew/spotlight_shadows_ignore_sun_h…
801fb14 
…eightmap
scpeters
scpeters reviewed Jul 14, 2021
View reviewed changes
Copy link

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change to the protobuf message is a problem

@WilliamLewww
Removed ABI breaking changes
6cc547d 
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@WilliamLewww
Added publisher for shadow caster material name
9e58ed1 
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@WilliamLewww
Updated XML namespace prefix for shadow_caster_material_name
6a9691f 
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@WilliamLewww
Added test worlds for integration test
1ddf223 
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@WilliamLewww WilliamLewww force-pushed the wlew/spotlight_shadows_ignore_sun_heightmap branch from 1a96d9f to b4e588e Compare July 19, 2021 15:46
@WilliamLewww
Added integration test for custom shadow caster materials
64a1bdb 
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@WilliamLewww WilliamLewww force-pushed the wlew/spotlight_shadows_ignore_sun_heightmap branch from b4e588e to 64a1bdb Compare July 19, 2021 15:49
@WilliamLewww WilliamLewww mentioned this pull request Jul 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilliamLewww @scpeters