Updated - WP.AlternativeFunctions: Add more functions to filesystem functions list #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will make it easier to see changes.
These functions were in the `VIP.FileSystemWritesDisallowed` sniff, and it seemed like a good idea to add them here as well.
dingo-d
reviewed
Nov 12, 2022
sandeshjangam
commented
Nov 12, 2022
jrfnl
requested changes
Dec 2, 2022
There was a problem hiding this comment.
Thanks for making this update @sandeshjangam ! Looking good.
I've left some small remarks. Other than that, could you please add some tests for the new functions ?
Adding tests for this, is basically just a case of adding a line with a function call to each of these functions in the WordPress/Tests/WP/AlternativeFunctionsUnitTest.inc file and then adding the line numbers for the lines containing those function calls to the WordPress/Tests/WP/AlternativeFunctionsUnitTest.php file.
jrfnl
added
Component: Extra
Type: Enhancement
Status: Awaiting feedback
Focus: WP interoperability
|
@sandeshjangam Just checking - will you have a change to update the PR in the next few days ? I'd like to include this in WPCS 3.0.0, but if not, I'll just move it out of the milestone. |
|
@jrfnl Trying to finish it today itself. I will update you here. |
dingo-d
approved these changes
Dec 16, 2022
|
@jrfnl Changes done as per suggestions and added test cases also. |
GaryJones
requested changes
Dec 16, 2022
jrfnl
reviewed
Dec 16, 2022
There was a problem hiding this comment.
Other than those things pointed out by @GaryJones, this PR looks good to me. Thanks for making those updates @sandeshjangam !
Co-authored-by: Gary Jones <github@garyjones.io>
Co-authored-by: Gary Jones <github@garyjones.io>
Co-authored-by: Gary Jones <github@garyjones.io>
|
Thanks for the feedback. All changes are done now. |
jrfnl
approved these changes
Dec 19, 2022
GaryJones
requested changes
Dec 19, 2022
GaryJones
approved these changes
Dec 19, 2022
GaryJones
added a commit
to Automattic/VIP-Coding-Standards
that referenced
this pull request
Dec 20, 2022
The ruleset tests were failing mainly due to WordPress/WordPress-Coding-Standards#2108 which renamed some violation codes that we were excluding. The other change to account for was the replacement of a WPCS StrictComparisons sniff with a PHPCSExtras Universal sniff. The sniff in PHPCSExtra contains a fixer. As this is a risky fixer, this fixer is turned off for WPCS. The sniff in PHPCSExtra will provide metrics about loose versus strict comparisons.
GaryJones
added a commit
to Automattic/VIP-Coding-Standards
that referenced
this pull request
Jun 20, 2023
The ruleset tests were failing mainly due to WordPress/WordPress-Coding-Standards#2108 which renamed some violation codes that we were excluding. The other change to account for was the replacement of a WPCS StrictComparisons sniff with a PHPCSExtras Universal sniff. The sniff in PHPCSExtra contains a fixer. As this is a risky fixer, this fixer is turned off for WPCS. The sniff in PHPCSExtra will provide metrics about loose versus strict comparisons.
GaryJones
added a commit
to Automattic/VIP-Coding-Standards
that referenced
this pull request
Jun 22, 2023
The ruleset tests were failing mainly due to WordPress/WordPress-Coding-Standards#2108 which renamed some violation codes that we were excluding. The other change to account for was the replacement of a WPCS StrictComparisons sniff with a PHPCSExtras Universal sniff. The sniff in PHPCSExtra contains a fixer. As this is a risky fixer, this fixer is turned off for WPCS. The sniff in PHPCSExtra will provide metrics about loose versus strict comparisons.
GaryJones
added a commit
to Automattic/VIP-Coding-Standards
that referenced
this pull request
Jun 22, 2023
The ruleset tests were failing mainly due to WordPress/WordPress-Coding-Standards#2108 which renamed some violation codes that we were excluding. The other change to account for was the replacement of a WPCS StrictComparisons sniff with a PHPCSExtras Universal sniff. The sniff in PHPCSExtra contains a fixer. As this is a risky fixer, this fixer is turned off for WPCS. The sniff in PHPCSExtra will provide metrics about loose versus strict comparisons.
GaryJones
added a commit
to Automattic/VIP-Coding-Standards
that referenced
this pull request
Jun 22, 2023
The ruleset tests were failing mainly due to WordPress/WordPress-Coding-Standards#2108 which renamed some violation codes that we were excluding. The other change to account for was the replacement of a WPCS StrictComparisons sniff with a PHPCSExtras Universal sniff. The sniff in PHPCSExtra contains a fixer. As this is a risky fixer, this fixer is turned off for WPCS. The sniff in PHPCSExtra will provide metrics about loose versus strict comparisons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1265
WP_File_Systemand remove any functions from the list which don't have aWP_File_Systemcounterpart.If there is no replacement function, the sniff would throw a non-actionable error/warning, which effectively is just noise.
WP_File_System), set those up in separate groups with an informative warning/error message.file_get_contents()from the list as it is already checked in another group in the same sniff (with logic to prevent triggering on opening of local files) and we don't want to throw duplicate notices.