Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated - WP.AlternativeFunctions: Add more functions to filesystem functions list #2108

Merged
merged 15 commits into from
Dec 19, 2022
Merged

Updated - WP.AlternativeFunctions: Add more functions to filesystem functions list #2108

Changes from 11 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
50ff813
WP.AlternativeFunctions: Order filesystem function list alphabetically
JDGrimes Dec 21, 2017
d3b3586
WP.AlternativeFunctions: Add more functions to filesystem functions list
JDGrimes Dec 21, 2017
61dc3dd
Removed file_get_contents() from the list as it is already checked in…
sandeshjangam Nov 11, 2022
e0a962a
Fixed conflict
sandeshjangam Nov 12, 2022
e3aa034
Seprated WP counter function and removed updated the list of filesyst…
sandeshjangam Nov 12, 2022
44bea02
Updated since of unlink function
sandeshjangam Nov 12, 2022
27cd9cb
Removed commented code
sandeshjangam Nov 12, 2022
844d2d4
Updated unlink function description
sandeshjangam Dec 16, 2022
076dd53
Fixed conlfict
sandeshjangam Dec 16, 2022
0ea5bc5
Updated file_system_read to file_system_operations
sandeshjangam Dec 16, 2022
08acd59
Added rename in separate category
sandeshjangam Dec 16, 2022
4a099da
Added test cases for new functions
sandeshjangam Dec 16, 2022
8dcd782
Update WordPress/Sniffs/WP/AlternativeFunctionsSniff.php
sandeshjangam Dec 19, 2022
5653e70
Update WordPress/Sniffs/WP/AlternativeFunctionsSniff.php
sandeshjangam Dec 19, 2022
10a814d
Update WordPress/Tests/WP/AlternativeFunctionsUnitTest.inc
sandeshjangam Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion WordPress/Sniffs/WP/AlternativeFunctionsSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,37 @@ public function getGroups() {
),
),

'file_system_read' => array(
'unlink' => array(
'type' => 'warning',
'message' => '%s() is discouraged. Use wp_delete_file() to delete a file.',
'since' => '4.2.0',
'functions' => array(
'unlink',
),
),

'rename' => array(
'type' => 'warning',
'message' => '%s() is discouraged. Use WP_Filesystem::move method to rename a file.',
sandeshjangam marked this conversation as resolved.
Show resolved Hide resolved
'since' => '2.5.0',
'functions' => array(
'rename',
),
),

'file_system_operations' => array(
'type' => 'warning',
'message' => 'File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: %s()',
sandeshjangam marked this conversation as resolved.
Show resolved Hide resolved
'since' => '2.5.0',
'functions' => array(
'chgrp',
'chmod',
'chown',
'is_writable',
'is_writeable',
'mkdir',
'rmdir',
'touch',
GaryJones marked this conversation as resolved.
Show resolved Hide resolved
'readfile',
'fclose',
'fopen',
Expand All @@ -139,6 +165,7 @@ public function getGroups() {
'file_put_contents',
'fsockopen',
'pfsockopen',
'fputs',
),
),

Expand Down