Admin PWA: Encode manifest data (#33310)

Fixes spaces in site title without replacing them with non breaking spaces.
WordPress · Jul 8, 2021 · 34d1a96 · 34d1a96
1 parent ad0cc77
commit 34d1a96
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/packages/admin-manifest/src/index.js b/packages/admin-manifest/src/index.js
@@ -1,7 +1,9 @@
 function addManifest( manifest ) {
  const link = document.createElement( 'link' );
  link.rel = 'manifest';
- link.href = 'data:application/manifest+json,' + JSON.stringify( manifest );
+ link.href = `data:application/manifest+json,${ encodeURIComponent(
+ JSON.stringify( manifest )
+ ) }`;
  document.head.appendChild( link );
 }
 
@@ -94,8 +96,7 @@ window.addEventListener( 'load', () => {
 
  const { logo, siteTitle, adminUrl } = window.wpAdminManifestL10n;
  const manifest = {
- // Replace spaces with non breaking spaces. Chrome collapses them.
- name: siteTitle.replace( / /g, ' ' ),
+ name: siteTitle,
  display: 'standalone',
  orientation: 'portrait',
  start_url: adminUrl,