Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode manifest data #33310

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Encode manifest data #33310

merged 1 commit into from
Jul 8, 2021

Conversation

walbo
Copy link
Member

@walbo walbo commented Jul 8, 2021

Description

Fixes spaces in site title without replacing them with non breaking spaces.

How has this been tested?

Locally

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

Encode manifest data
c74fe6e 
Fixes spaces in site title without replacing them with non breaking spaces.
@walbo walbo requested a review from ellatrix as a code owner July 8, 2021 19:25
ellatrix
ellatrix approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Makes perfect sense.

@ellatrix ellatrix merged commit 34d1a96 into WordPress:trunk Jul 8, 2021
@github-actions github-actions bot added this to the Gutenberg 11.1 milestone Jul 8, 2021
@walbo walbo deleted the encode-manifest-data branch July 8, 2021 21:16
sarayourfriend pushed a commit that referenced this pull request Jul 15, 2021
@sarayourfriend
Admin PWA: Encode manifest data (#33310)
c6ef6f3 
Fixes spaces in site title without replacing them with non breaking spaces.
@priethor priethor mentioned this pull request Jul 19, 2021
Merged
12 tasks
@westonruter westonruter mentioned this pull request Jul 21, 2021
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix ellatrix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@walbo @ellatrix