Fix regression with unclickable block warnings (#11768)

* Fix regression with unclickable block warnings Fixes #11764. This PR makes the "Resolve" and "Convert to HTML" buttons clickable again. * Add comments.
WordPress · Nov 13, 2018 · 38001c6 · 38001c6
1 parent c206d07
commit 38001c6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/editor/src/components/block-list/style.scss b/packages/editor/src/components/block-list/style.scss
@@ -201,10 +201,16 @@
 
 	// Warnings
 	&.has-warning .editor-block-list__block-edit {
-		> :not(.editor-warning) {
+		// When a block has a warning, you shouldn't be able to manipulate the contents.
+		> * {
 			pointer-events: none;
 			user-select: none;
 		}
+
+		// Allow the warning action buttons to be manipulable.
+		.editor-warning {
+			pointer-events: all;
+		}
 	}
 
 	&.has-warning:not(.is-hovered) .editor-block-list__block-edit::before {

diff --git a/packages/editor/src/components/warning/style.scss b/packages/editor/src/components/warning/style.scss
@@ -34,7 +34,6 @@
 
 	.editor-warning__action {
 		margin: 0 6px 0 0;
-		margin-left: 0;
 	}
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -34,7 +34,6 @@ @@
     	.editor-warning__action {
     		margin: 0 6px 0 0;
-    		margin-left: 0;
     	}
     }
@@ Expand Down @@