Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression with unclickable block warnings #11768

Merged
merged 2 commits into from
Nov 13, 2018
Merged

Fix regression with unclickable block warnings #11768

merged 2 commits into from
Nov 13, 2018

Conversation

jasmussen
Copy link
Contributor

Fixes #11764.

This PR makes the "Resolve" and "Convert to HTML" buttons clickable again.

screenshot 2018-11-12 at 17 20 01

@jasmussen
Fix regression with unclickable block warnings
d889e0b 
Fixes #11764.

This PR makes the "Resolve" and "Convert to HTML" buttons clickable again.
@jasmussen jasmussen added the [Type] Regression Related to a regression in the latest release label Nov 12, 2018
@jasmussen jasmussen added this to the 4.4 milestone Nov 12, 2018
@jasmussen jasmussen self-assigned this Nov 12, 2018
@jasmussen jasmussen requested review from johngodley and a team November 12, 2018 16:21
tofumatt
tofumatt approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it'd be ace to have a regression test for this one. I'll try to cook one up real quick.

packages/editor/src/components/block-list/style.scss Show resolved Hide resolved
@mkaz
Copy link
Member

mkaz commented Nov 12, 2018

Tested and confirmed this fixes the issue of buttons not being clickable.

@jasmussen jasmussen mentioned this pull request Nov 13, 2018
Closed
@tofumatt
Copy link
Member

FYI I couldn't cook up a test quickly for this, obviously. 😓

@jasmussen
Copy link
Contributor Author

FYI I couldn't cook up a test quickly for this, obviously. 😓

No worries, I think @johngodley might look at one separately, see #11764 (comment)

@jasmussen jasmussen merged commit 38001c6 into master Nov 13, 2018
@jasmussen jasmussen deleted the fix/block-warning branch November 13, 2018 10:23
johngodley added a commit that referenced this pull request Nov 13, 2018
@johngodley
Add e2e test for invalid blocks
0cb8177 
Test that the invalid block warning appears and that buttons are clickable. Should cover the issue fixed in #11768
@johngodley johngodley mentioned this pull request Nov 13, 2018
Merged
johngodley added a commit that referenced this pull request Nov 14, 2018
@johngodley
Add e2e test for invalid blocks (#11814)
d63ed47 
Test that the invalid block warning appears and that buttons are clickable. Should cover the issue fixed in #11768
@mtias mtias mentioned this pull request Nov 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZebulanStanphill ZebulanStanphill ZebulanStanphill left review comments

@aduth aduth aduth left review comments

@youknowriad youknowriad youknowriad left review comments

@tofumatt tofumatt tofumatt approved these changes

@johngodley johngodley Awaiting requested review from johngodley

Assignees

@jasmussen jasmussen

Labels
[Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@jasmussen @mkaz @tofumatt @youknowriad @aduth @ZebulanStanphill