-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks: Add cog to the side of block, as a shortcut to "advanced" inspector controls #1251
Comments
Interesting, yes this could help #1182. The tab order will be key, as the cog and delete button should be placed in the most logical order when tabbing. Of course, both buttons would need some aria-label to be properly labeled. |
Do you have any thoughts on what the best tab order would be? It appears visually as though they would occur after the fields, but for consistency with the rest of the controls, I would think they should be part of the series with movers -> toolbar -> cog / delete. |
Looking also at #130, yes I tend to think the cog and delete buttons should be part of the movers > toolbar, for consistency and also because it's "one place less" to look at. Not sure about the visual part. The mockup with the delete button within the toolbar makes the logical grouping match the visual grouping, see #130 (comment) and I do like it, just my personal opinion. |
Not the intention, though undo / redo is admittedly very basic and incomplete at the moment (partially tracked at #627). |
Good to know! 👍 |
See #1372 that is going to add a "cog" button, however that's used just to open the sidebar. |
This is done. |
Mockup:
The cog there on the right will open the inspector when you click it. That is, if the sidebar is closed, it will open the sidebar.
It should show up only when a block has advanced inspector controls (see #1100).
This button can also address an accessibility issue, see #1182. CC: @afercia
The text was updated successfully, but these errors were encountered: