Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing backspace doesn't delete an empty freeform block #1273

Closed
aaronjorbin opened this issue Jun 19, 2017 · 7 comments
Closed

Pressing backspace doesn't delete an empty freeform block #1273

aaronjorbin opened this issue Jun 19, 2017 · 7 comments
Assignees

Comments

@aaronjorbin
Copy link
Member

If a freeform block is empty, pressing backspace doesn't remove the block. The freeform block should likely behave the same way as the text block in this instance.

related to the act of deleting blocks: #130 #1181 #1251

@mtias
Copy link
Member

mtias commented Jun 22, 2017

@EphoxJames would you mind looking into this one when you have a moment?

@BoardJames
Copy link

@mtias I'll look into it today. It will probably be a simple matter of copying the relevant handler from the text block.

@jasmussen
Copy link
Contributor

@EphoxJames I can still reproduce this. Have a chance to look at this?

@BoardJames
Copy link

Well the freeform block was taken over by @iseulde a while ago so since that happened I've been concentrating on other things - most recently keyboard navigation ( #2392 ).

Currently freeform block doesn't use any of the merge / split callbacks. I imagine to get this working I would call the merge callback when the block was empty which shouldn't be too hard to implement so I will give it another try.

(PS. Aren't you meant to be on leave. :-P )

@jasmussen
Copy link
Contributor

(PS. Aren't you meant to be on leave. :-P )

Hah, yes, the boy is meant to arrive today! But I'm not leaving until it's time, and like any good wizard he will arrive precisely when he means to.

@BoardJames
Copy link

I have a pull request to fix this issue at #2482 anyone want to review it?

@BoardJames
Copy link

I've merged the fix so this issue should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants