-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advisory banners need to changes and implemented as something else. #13905
Comments
Hi @irishetcher — A recent PR #13614 has recently changed the way these work. Notices will no longer appear on top of the actual content, blocking it from view. They instead push the content down the page a bit. Please take a look and let me know if that's similar to what you had in mind. |
@jasmussen Could you weigh in on whether you'd consider this as satisfied by recent improvements in #13614 ? Otherwise, we should direct this issue to actionable tasks. |
Hey! Thanks for the ticket. Yes, the recent PR should drastically improve how these notices work:
I do personally agree that notices as a whole, in all of WordPress actually, can benefit from both visual and technical upgrades, and some diversification, though I'm unsure if there's bandwidth to tackle these in the immediate ongoing phase. Take the Material Design system, for example, they have the concept of "banners", which roughly correlate to what we have for notices: https://material.io/design/components/banners.html But they also have a concept called a "snackbar", which can make sense for some prompts: https://material.io/design/components/snackbars.html Figma uses a snackbar for informing you that it automatically saves documents. In this GIF I pressed ⌘S three times in a row: We might not want to copy that particular notification, but I would love to see a system for snackbars in WordPress, so we can show a little message that says "Copied to clipboard!" when you press the "Copy All Content" button in the More menu. That might be the actionable next step: consider a new component for "snackbars", and consider for which actions to show it, and for which existing notices to convert to snackbars. Thoughts? |
I think that's a great idea. To help think about what kind of messages would use this new type of notice, I'd consider these guidelines:
Here's another example https://ant.design/components/message/ |
I like the idea of having temporary, out-of-the-way notifications — our current notification system is pretty clunky. I do worry a little bit about third-party usage, though. I was wondering about a11y settings, and found this on Angular's Material components doc:
I almost feel like it would be better to use snackbars for anything that doesn't require an additional action, and have them only be used for immediate feedback on a particular action. |
Some more examples: Polaris: https://polaris.shopify.com/components/feedback-indicators/toast#navigation Also — Toast? Snackbars? Why are we like this, internet friends? Do we need a snack? |
If the bar is transitory (ie: auto dismisses as per Material guidelines) then it might be less open to abuse as any messages wouldn't be persisted to the UI. I'm very interested in seeing something like this land, but it would require careful usage guidance. |
A webdesigner walks into a bar. Bartender asks, what'll it be? Webdesigner says:
|
Hello, coming from #14402 I went back to review the original merged request #13614 and wonder if the overlap issue can simply be resolved by removing the distinction between dismissable and non-dismissable notices on scroll. If they were to all simply stay in position instead of being sticky they still serve their purpose, don't require much extra effort and avoid interference with the editor interface. Once a user scrolls or is interacting with the blocks the notices should take a backseat, they'll always be there on reload or page navigation and scroll back to the top. Sorry I hope that thought makes sense. Thank you for the continuously intrepid innovations. Cheers |
One concern worth noting is that if you are working on a long document and press "Publish", you are unlikely to see the notice that the publication was succesful because the banner will be out of sight way at the top. I would suggest that the snackbar as is described in #13905 (comment) is a great way to address that issue — they are transient, contextual, and not disruptive. |
Thanks @jasmussen I see what you mean with the publish notice, I was thinking that would reload the screen and leave you at the top like it did with Classic Editor. I agree in those cases where the information is relevant to the editor such as the publish/update or block errors would make more sense in the transient snackbar as they'll be less intrusive and go away after time so won't need a dismiss action. I definitely second the comment you referenced there. |
I am removing the 'User Experience (UX)' label as part of a label cleanup. It's not being used anymore consistently so let's try and keep to 'needs design' and 'needs design feedback'. If we find a need for another label we can consider it but having those 2 should cover this. |
Since we have a 'headless' setup, with Wordpress on one domain and the actual site on another (via the REST API data and Angular), prior to Gutenberg, we could alter the 'View Post' text and link via the This new snackbar does not appear to respect any changes made with that filter. (The text used in the snackbar is set within |
Is your feature request related to a problem? Please describe.
Change the advisory banners that appear over the title when page is published, updated or when there is an auto-save warning etc. This UX implementation looks clumsy and doesn't fit with the general look of the new block editor
Describe the solution you'd like
Something a bit more subtle elsewhere in the interface. Something dynamic like if you temporarily displayed in the top bar over by the Preview / Update buttons. Or, even if the the View Post item in the admin did some sort of subtle highlighting to suggest that should be clicked.
Describe alternatives you've considered
Sorry if I don't have any concise suggestions but I think that the new block editor needs a little bit more polish here and elsewhere.
The text was updated successfully, but these errors were encountered: