Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the List block with basic HTML list types #17738

Closed
paaljoachim opened this issue Oct 3, 2019 · 33 comments · Fixed by #51186
Closed

Improving the List block with basic HTML list types #17738

paaljoachim opened this issue Oct 3, 2019 · 33 comments · Fixed by #51186
Assignees
Labels
[Block] List Affects the List Block [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

Hey

My customer wants it to look like this:
Screen Shot 2019-10-02 at 08 16 47

This seems like a challenge for the list block.
There are multiple things to consider. Checkmarks, numbers, letters, roman numbers etc. Then also having the list horizontal instead of vertical.

I would suggest to have drop down of the prefix icons. Similar to what we do with alignment options in other blocks.

That could mean a drop down with name such as ordered list and the icon. Followed by names and icons of other options.

One would then check the drop down and select the type of icon one wants to use.

Mockup:
Improving-list-block

Additionally

Then also add an alignment option drop down similar to other blocks. To show the list in
Horizontal or vertical mode.

@CalumChilds
Copy link

For the checks in the list, there could be an option where the user could upload an SVG/PNG image which could be used as a bullet.

Also, whilst we're on the subject of improving the List block,I think there should be a number of ways that the numbers can be displayed (roman numerals, indented lists with 1, 1.1, 1.1.1 etc.) that the user can choose from.

@joyously
Copy link

joyously commented Oct 4, 2019

I wonder how much of this should be in the core block and how much should just be styles added by a plugin.

Does the current list block expose the start attribute? How about the reversed attribute?

@CalumChilds
Copy link

The horizontal - vertical option should be added by a plugin or custom CSS, as it's something most users won't want or need.

However, I do think that with the numbers, such as the roman numerals, maybe we should have the numbering options that are provided in Microsoft Word:
image
And, in terms of the bullet styles, there should be these options:

  • filled-in circle (default)
  • circle outline
  • filled-in square
  • use an image as a bullet (PNG)

@mcsf mcsf added the [Type] Enhancement A suggestion for improvement. label Oct 8, 2019
@skorasaurus
Copy link
Member

skorasaurus commented Nov 26, 2019

Regarding bullet styles, there's a couple issues that also mention it #9117, #15005, and #13888

@joyously as I understand, the current block exposes both the start and the reversed attribute.

@phpbits
Copy link
Contributor

phpbits commented Jan 3, 2020

@paaljoachim Just wanted to let you know that I've just added few list block styles on EditorsKit Plugin. Here's the preview and I hope you'll love it. Cheers!

https://twitter.com/editorskit/status/1213105775632977921

gutenberg-list-block-styles

@joyously
Copy link

joyously commented Jan 3, 2020

How does that connected one look with nested lists? Or with text that wraps to a second line?

@joyously
Copy link

joyously commented Jan 3, 2020

as I understand, the current block exposes both the start and the reversed attribute.

I just tested this, and the attributes are only available on the outermost list.

@phpbits
Copy link
Contributor

phpbits commented Jan 3, 2020

I just tested this, and the attributes are only available on the outermost list.

The style will also be applied on the nested list :)

@paaljoachim
Copy link
Contributor Author

Design folks really need to go through this issue. Thanks a lot for sharing Jeffrey! I look forward to seeing your List Block improvements make it's way into GB Core.
@karmatosed @mapk

@karmatosed
Copy link
Member

Let's get the design feedback label on this so we can dive into some thinking here. I do first off think we need to be cautious about what we add here as a lot can be done with a combination of styles and also a class.

I'd be cautious as a result of my above comment to add a way to upload an image. I think there's a lot can be done with maybe another block style variation (maybe a couple), but I don't think making this too complex is the way to go. I also think this should be done under style variations over in toolbar.

@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Jan 13, 2020
@mapk
Copy link
Contributor

mapk commented Jan 13, 2020

I would suggest to have drop down of the prefix icons.

I actually like the block styles option that @phpbits proposed as a way to do this. We don't need to provide every possible bullet symbol, but a good few that are common to use.

Then also add an alignment option drop down similar to other blocks.

This reminds me of the Navigation block and might be worth an exploration there if it hasn't happened yet.

In either case, providing more bullet options sounds good to me. Using them as block styles opens them up for plugins to easily expand and add their own styles too.

@strarsis
Copy link
Contributor

strarsis commented Mar 2, 2020

Please make nested lists stylable! This is easily possible with HTML and I can indeed achieve the same in editor by manually adding the is-style-* classes to nested <ul> and </ol> elements, but it appears that the editor removes them when changing the uppermost list block (e.g. changing its block style).
Also it is currently not possible to return back to list item when a nested list has been added to it:

  1. Top 1
  2. Top 2
  3. Level 2
    1. Level 3
    2. Level 3
    Back to same item!
  4. Top 3
  5. Top 4

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Apr 2, 2020

One focus area is to add styles to the List Block such as Jeffrey mentioned in his comment above. #17738 (comment)
I also made an animated gif.

List-Block-Styles

I would suggest that we add these styles into the Core List Block:
Default
None
Arrow
Checked
Dashed
Starred

Another would be checkboxes.

@mapk
Copy link
Contributor

mapk commented Apr 14, 2020

It seems there's some consensus around adding a variety of bullets to the List block. Using the style variations for this purpose feels like the right way to go. Shall we move this to dev?

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Apr 14, 2020
@paaljoachim
Copy link
Contributor Author

Hey Jeffrey. @phpbits
Can you add some styles to the block?

@zdenys
Copy link

zdenys commented Aug 5, 2020

Additionally
Then also add an alignment option

This would be really nice indeed, as compared to the paragraph block, list one is missing the alignment option but also justify option. Having both for parity would be good.

Paragraph List

@joyously
Copy link

joyously commented Aug 5, 2020

@zdenys What else do you have installed?
There is no Justify option. It was removed from WP years ago, and not added back in the new editor. This screenshot is from WP 5.5RC2:
para-menu

@strarsis
Copy link
Contributor

strarsis commented Aug 5, 2020

Note: The EditorsKit plugin adds a justify option.

@zdenys
Copy link

zdenys commented Aug 6, 2020

@zdenys What else do you have installed?
There is no Justify option. It was removed from WP years ago, and not added back in the new editor. This screenshot is from WP 5.5RC2:

The screenshots I provided are from a site with only Gutenberg plugin version 8.7.0. and Jetpack version 8.8. In fact, it may be coming from the latter as when I deactivated it, I could see the justify option disappear.

@strarsis
Copy link
Contributor

strarsis commented Aug 6, 2020

@zdenys: Yes, the Jetpack plugins adds a justify format option to Gutenberg.

@mtias
Copy link
Member

mtias commented Aug 30, 2020

I think this is more plugin territory. Unless we were to support any symbol / emoji, which might be worth exploring, specific style variations can quickly become dated while still needing to be supported for a long time.

@CalumChilds
Copy link

@CHEWX I think we should get this in for WP 5.6.

@createscape
Copy link

I am just working on a legal document in Gutenberg and found that I couldn't style the nested lists with different numbering system ( lowercase or roman numerals inside numbered list). Editing the HTML didn't work either and I found this frustrating (assuming it's because Gutenberg isn't actually using HTML ). I had to add a CSS class to remove the list items of the nested lists and just type in the lowercase and roman numerals.

@annezazu
Copy link
Contributor

annezazu commented May 2, 2022

The ability to have more options rather than bullets or 1,2,3 came up in the FSE Outreach Program's fourteenth call for testing. Specifically, there was a desire to offer a, b, c options.

I think it would be interesting to explore as possible style variations for the block!

@solaceten
Copy link

Hello, I am wondering if this will get implemented and when? It would also be nice to have the ability to add list style e.g. A) B) C) etc

@kohheepeace
Copy link

kohheepeace commented Oct 19, 2022

I think emoji is better than preset default style.

2022-10-20 01 27 19

[Idea]:

  • Add emoji attribute to core/list
  • Add InspectorControls with emoji-mart to allow user select emoji
  • Inline css to ul when user select emoji
<ul style="list-style-type: "📌";">
...
</ul>

[caveat]:

  • It does not support nested list
  • It does not support Serial number style

@druxstr
Copy link

druxstr commented Nov 5, 2022

I feel this issue tries to address 2 different problems and should be split to better solve them.

  1. Adding cosmetic list types (checks, stars, pins, emojis, etc.)
  2. Adding basic HTML list types (letters, Roman numerals)

Cosmetic list types are about <ul>. They may be better dealt by a plugin.

Basic HTML list types are about <ol>. They should be dealt by core.

What's at stake isn't the same.

With no support for basic HTML types, nested ordered list are barely usable in Gutenberg. With no support for stars and emojis, unordered lists still work.

@mtias
Copy link
Member

mtias commented Nov 15, 2022

@druxstr that's a good point, would be good to split.

@annezazu annezazu changed the title Improving the List block Improving the List block with basic HTML list types Nov 16, 2022
@annezazu
Copy link
Contributor

Changed the title of this issue and created a new one for cosmetic list types to better split things out: #45830

@priethor priethor added this to Polish Apr 28, 2023
@priethor priethor moved this to Needs development in Polish Apr 30, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 2, 2023
@paaljoachim
Copy link
Contributor Author

Yess!
@glendaviesnz has created a PR here: #51186 go and check it out and give feedback!

@jasmussen
Copy link
Contributor

I shared some design thoughts in #51186 (comment) that might be relevant to this issue.

@apeatling apeatling moved this from Needs development to In progress in Polish Jun 6, 2023
@richtabor richtabor moved this from In progress to Done in Polish Jun 19, 2023
@priethor priethor removed [Status] In Progress Tracking issues with work in progress Needs Dev Ready for, and needs developer efforts labels Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.