Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The inline Inserter position jumps #23081

Closed
MichaelArestad opened this issue Jun 10, 2020 · 7 comments
Closed

The inline Inserter position jumps #23081

MichaelArestad opened this issue Jun 10, 2020 · 7 comments
Assignees
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended

Comments

@MichaelArestad
Copy link
Contributor

Describe the bug
When hovering over the inserter between blocks, it jumps. At first I thought my animation was problematic when working on the hover delay and animation speed. Then, I looked a bit closer. It seems the Inserter is actually moving causing some serious jank.

To confirm this, I shortened the animation and delay to almost 0. It makes it really clear what is happening. You can see it in this gif:

2020-06-10 15 57 27

To reproduce

  1. Add a few paragraph blocks.
  2. Hover slowly right below where the inserter. It's hard to figure out unless you dramatically shorten the animation time found here to something like 0.01s. You might also remove this 80% bit here.

Expected behavior
I expect the inserter to not jump.

Editor version (please complete the following information):

  • WordPress version: 5.4.1
  • Gutenberg master

Desktop (please complete the following information):

  • OS: MacOS latest
  • Browser: Firefox latest
@MichaelArestad MichaelArestad added [Type] Bug An existing feature does not function as intended [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels Jun 10, 2020
@MichaelArestad MichaelArestad self-assigned this Jun 10, 2020
@paaljoachim paaljoachim added the [Priority] High Used to indicate top priority items that need quick attention label Jun 23, 2020
@paaljoachim
Copy link
Contributor

Let's get this bug squashed..:)

@ZebulanStanphill
Copy link
Member

I've definitely seen this weirdness before, but I never dug into it to find out exactly what triggered it. Thanks for looking into it and creating this issue, @MichaelArestad!

@paaljoachim paaljoachim removed the [Priority] High Used to indicate top priority items that need quick attention label Jun 25, 2020
@ellatrix
Copy link
Member

I've done some refactoring in #20792 while fixing another bug. I'm not noticing any issues after that. Could you retest with master?

@MichaelArestad
Copy link
Contributor Author

@ellatrix I tested on master and I'm still seeing it.

To reproduce:

  1. Create a new post/page
  2. add several paragraphs in a row
  3. Move your cursor over the inserter icon and move very slowly downward (very slow). It's not consistent so try between more than one paragraph.

@youknowriad
Copy link
Contributor

Due to how difficult it is to reproduce this and the severity, I'm removing this from the 5.5 Must-Haves.

@MichaelArestad
Copy link
Contributor Author

@youknowriad sounds good as long as we eventually figure it out. Keep up the good work!

@talldan
Copy link
Contributor

talldan commented Jul 21, 2021

I haven't seen this happen for a while now and I just tested and can't reproduce. I believe the code for the in-between inserter was reworked quite a bit, and it seems much more reliable. I'll close this, but can always reopen or open a new issue if it reoccurs.

@talldan talldan closed this as completed Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

6 participants