-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try: Reduced inserter hover delay. #23046
Conversation
Alternative to #23043, props @MichaelArestad. This one is faster, but still delayed.
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
@jasmussen This is an improvement over mine because the jank isn't noticeable. That said, I think the jank is unrelated to animation speed. I think it's an issue with the inserter actually moving. In this PR I was able to see some jank (just looking at my cursor icon) and even reproduce the inserter showing up in the wrong spot: |
This is definitely an improvement but the delay is so subtle that my first instinct was wondering if my browser had glitched. I also noticed some slightly jumpiness in Safari, possibly due to subpixel rounding related to the animation. The icon seems to move ever so slightly. |
I just tried #23043 and I have to admit other than the slight animation wonkiness the timing feels a lot better. It feels responsive without me wondering if Chrome just crashed 😅 |
@chrisvanpatten Looks like it's a bug with the inserter teleporting. Your Chrome is fine. |
Thanks for all the feedback. It looks like we have a few paths forward. We can either:
I'm leaning towards 1 for the time being, because people are seeming to think the sibling inserter has been removed entirely, due to the current delay. But open to thoughts! |
@jasmussen because it's such a trivial PR for me to make (and I have the values memorized at this point), I think we should go ahead with option 1 until that bug gets fixed. |
Cool, feel free to give me a thumbs up for this one then. Thanks. |
Alternative to #23043, props @MichaelArestad.
This one is faster, but still delayed.