Speed up hover timing for inserter #23043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelArestad
added
[Type] Enhancement
|
Size Change: +4 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
jasmussen
pushed a commit
that referenced
this pull request
Jun 10, 2020
Alternative to #23043, props @MichaelArestad. This one is faster, but still delayed.
|
Nice, thank you for the PR! This is what I see before:
This is what I seee after:
Honestly this feels both a little flickery, and too fast. It doesn't seem to solve the problem that was initially the genesis of the delayed fade-in — overlap with resize handles such as those in the spacer or cover blocks. In #23046 I tried an alternative that's still delayed, but much less so. It doesn't flicker, even if the fade isn't very smooth (not enough frames). I realize with the 0 until 80% fade that I'm "faking" a delay, but that's because actual delay property did not appear to work very well for this. I think it works a little better:
We could also try a different approach: That looks like this which seems an okay balance?
What do you think? |
|
@jasmussen It turns out the jank is likely caused by inserter jumping. I made an issue that really shows it well where I reduced the animation to almost zero. |
|
Thanks for creating that issue. In the mean time, should we go with the slightly weird syntax that at least works around that issue? |
jasmussen
added a commit
that referenced
this pull request
Jun 12, 2020
Alternative to #23043, props @MichaelArestad. This one is faster, but still delayed. Co-authored-by: Joen Asmussen <asmussen@gmail.com>
6 tasks
|
Can this one be closed now that #23046 is merged? |
|
@jasmussen Yep. Closing. Will create a new one if that bug gets fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by conversation in #22813 and in response to #22801, I sped up the timing and dramatically reduced the delay of the hover animation on the inserter.
I'm going for a delay just long enough to allow you to move your cursor over several blocks without flashing the inserter, but fast enough where the inserter is still discoverable.
I am noticing a bug that I don't think is related to this PR and would appreciate someone else confirming it. When hovering around the inserter, sometimes it flashes extremely quickly. I think this has to do with the location of the mouse being misinterpreted by the inserter JS or something as if I mouse just right, the inserter appears in the wrong spot. Gif below:
How has this been tested?
I tested this on FF (latest) on MacOS (latest).
Screenshots
Screenshots just don't do this justice and gifs are a bit stuttery. It's probably better to test yourself to get a feel for it.
Checklist: