Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo undefined #2612

Closed
2 tasks
stmarytx opened this issue Aug 30, 2017 · 1 comment · Fixed by #2616
Closed
2 tasks

Vimeo undefined #2612

stmarytx opened this issue Aug 30, 2017 · 1 comment · Fixed by #2616
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@stmarytx
Copy link

WP 4.8.1 with Gutenberg 1.0.0

Issue Overview

When a Vimeo block is added, but no Vimeo link entered, the front end public view is showing "undefined"

Steps to Reproduce (for bugs)

  1. Add two text blocks, then a Vimeo block between them
  2. Leave the Vimeo URL input blank
  3. Publish the post
  4. View the published post which contains "undefined" where the Vimeo block should be

Expected Behavior

If a video block URL is left blank, I'd expect nothing to appear for that block - I would just see the block above and the block below, no Vimeo block at all.

Current Behavior

Vimeo block displays "undefined" instead of not appearing.

Possible Solution

On the block display end, first check for a valid video URL. If one doesn't exist, simply do not display the block.

Related Issues and/or PRs

Todos

  • Tests
  • Documentation

Issue visible on test site at: http://s20923.p221.sites.pressdns.com/2017/a-fancy-news-story/

@aduth aduth added [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended labels Aug 30, 2017
@aduth aduth self-assigned this Aug 30, 2017
@aduth
Copy link
Member

aduth commented Aug 30, 2017

Somewhat related to discussion of how to handle empty blocks: #1181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants