Blocks: Save embed with empty markup when URL not selected #2616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2612
This pull request seeks to resolve an issue where a
figure
with text "undefined" is saved into post content for an embed block, if a URL is not yet assigned to the block.Open questions:
In cases such as these where a block has a placeholder state, is it sensible to save the block at all, or would it make more sense to omit the block from the saved content? There may be technical challenges in implementing this behavior.
Testing instructions: