Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable rich previews for custom links in the Navigation Block and Editor #32555

Closed
Tracked by #35521
getdave opened this issue Jun 9, 2021 · 0 comments · Fixed by #36412
Closed
Tracked by #35521

Enable rich previews for custom links in the Navigation Block and Editor #32555

getdave opened this issue Jun 9, 2021 · 0 comments · Fixed by #36412
Assignees
@georgeh @getdave
Labels
[Block] Navigation Affects the Navigation Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Status] In Progress Tracking issues with work in progress

Comments

@getdave
Copy link
Contributor

getdave commented Jun 9, 2021

What problem does this address?

The introduction of rich previews for remote URLs in #31464 only applies to the post editor and only then to usage within core/paragraph (strictly anything that utilises the @wordpress/format library package).

We should enable this feature in the Nav Block and Editor to provide a rich user experience.

What is your proposed solution?

  1. Set the hasRichPreviews prop on <LinkControl> within the core/navigation-link component.
  2. Wire up the __experimentalFetchRemoteUrlData API to be available within the Nav Editor.
@getdave getdave added [Block] Navigation Affects the Navigation Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Feature] Navigation Screen labels Jun 9, 2021
@getdave getdave self-assigned this Jun 9, 2021
@priethor priethor mentioned this issue Oct 11, 2021
Closed
38 tasks
georgeh pushed a commit that referenced this issue Nov 11, 2021
Enable Previews for Navigation Link Blocks
9f3238c 
Closes #32555
@georgeh georgeh mentioned this issue Nov 11, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 11, 2021
georgeh pushed a commit that referenced this issue Nov 12, 2021
Enable Previews for Navigation Link Blocks
63bb694 
Closes #32555
georgeh added a commit that referenced this issue Nov 12, 2021
@georgeh
Enable Previews for Navigation Link Blocks (#36412)
23412da 
* Enable Previews for Navigation Link Blocks in the Navigation editor and block editor

Closes #32555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgeh georgeh

@getdave getdave

Labels
[Block] Navigation Affects the Navigation Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable Previews for Navigation Link Blocks WordPress/gutenberg
2 participants
@georgeh @getdave