Enable Previews for Navigation Link Blocks #36412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +23 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
|
In order to address 2. — enabling rich previews on the navigation editor — from #32555, we have to import packages/edit-navigation/src/index.js import {
__experimentalFetchUrlData, // import this
__experimentalFetchLinkSuggestions as fetchLinkSuggestions,
store as coreStore,
} from '@wordpress/core-data';
// ...
const editorSettings = useMemo(() => {
return {
...settings,
__experimentalFetchLinkSuggestions,
__experimentalSetIsInserterOpened,
__experimentalFetchRichUrlData: __experimentalFetchUrlData // pass it to the settings
};
}, [
settings,
__experimentalFetchLinkSuggestions,
__experimentalSetIsInserterOpened,
]);
|
|
Ahh, thanks @vcanales - I was checking the editor in FSE not in the navigation editor itself. |
georgeh
requested review from
adamziel,
draganescu,
getdave,
kevin940726 and
talldan
as code owners
georgeh
force-pushed
the
add/navigation-link-previews
branch
from
537c451
to
22afda0
Compare
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32555
Description
Adds rich previews for Navigation Links
How has this been tested?
Tested in post editor and navigation editor.
Screenshots
Screen.Recording.2021-11-11.at.11.15.23.AM.mov
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).