-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-Introduce Content Editing in the Site Editor #44461
Comments
One option (which overlaps with Browse Mode) would be to present the web site in a frame upon entering the Site Editor (a concept first introduced in https://make.wordpress.org/design/2022/06/13/thinking-through-the-wordpress-admin-experience/). The frame could feature a dynamic address bar, allowing folks to search for content to display and edit: browse.mp4One problem with the previous drill-down approach was the fatigue it caused when navigating deep into content trees. The dynamic address bar solves this. Another benefit is the obfuscation between content and some templates, for example it seems reasonable to surface the 404 template if one were to search for it here. |
I like that minimal browse mode for allowing you to choose content to edit, if we pair it with an explicit "Templates" item in the sidebar for when editing that is your intent. The bigger win would be to not drop you directly into editing your "Home" template, rather to allow you to make a choice first in the open-by-default sidebar. Should we try and prototype a minimal version of that? Someting like:
This would let us still have a generic template list as it exists today, and could be a small step towards true browse mode where links in the viewport actually become clickable. What do you think? |
100%. I think it's vitally important that we place template editing / management at an appropriate altitude in the UX. It's over-emphasis one of the biggest overall sources of confusion in the site editor.
That's certainly an option, though I find the "Site" button a little awkward, and it's quite buggy (#42807, #36821). We might place Templates in a drill-down instead. That is aligned with the de-emphasisation of template management mentioned above, and would eliminate the need for the buggy "Site" button. As an added bonus it'd create space for us to delineate different template (and part) types, which is something that has come up in #42325. Here's a demo: templates.mp4If that leap is too large, then your suggestion sounds like a good middle-ground to me. |
I like the idea that you see the viewport and are able to click "Edit" to edit the content. I think it's too early to put Templates inside the "Library", I would intuit mainly custom stuff be placed there. Which yes, arguably you can create custom templates, but it still feels as stretch, so to reduce drilldown we should probably keep templates top level for now, IMO. |
As a small update, a navigation interface was recently merged: The feature isn't yet implemented, but clicking a navigation item in the sidebar on the left, is also meant to load that page in the view on the right. It's a nascent taster of "browse mode", as the view on the right should similarly be navigable. It also doesn't preclude a separate "Content" drilldown to let us search pages, posts, or otherwise. But nevertheless, it's a small status update for this one. |
I mentioned this in today's Core Editor Chat, but I wanted to also share it here for the record. Given how close we are to the feature freeze of 6.2, introducing this without the ability to test it in a few Gutenberg plugin release cycles would be rushing it. I really want this feature to be available asap. But less than a week before the feature freeze doesn't leave much time for testing & fine tuning the experience. Happy to be proven wrong though if anyone disagrees. |
Thanks @fabiankaegy, I have moved this to "In discussion, needs decision" on the board. |
To expand on @jasmussen's earlier comment, one idea that has bubbled up in design discussions around #36667 is that a document-level panel in the drilldown menu area could be a useful design pattern. Clicking a page in the Navigation panel does two things:
To begin with the panel can start simple – perhaps it only contains the title, publish date, and Edit button. But as demonstrated in the diagram above, in the future we can expand this to include high-level edit capabilities such as changing the template, featured image, etc. By allowing the document-level panel to contextualise what is visible in the frame, the burden on the 'site hub' is lessened so that it can probably revert back to displaying the site title. If this pattern works well we can use it in other sections like Templates. A template drilldown could (for example) offer quick ways to change the header / footer, or select a pattern for the entire template, without having to engage the 'full' editor. cc @youknowriad |
@jameskoster, now that #47387 is merged and #47777 is in progress. What are the remaining items for this feature? |
I think the final piece required to close this issue will be a method of accessing content that is not represented in the main navigation. For example editing an individual post. I've seen 'command palette' concepts shared elsewhere, e.g: command.palette.mp4But I don't know if we're 100% ready to commit to that yet. |
No worries at all 👍 Here's something folks can play around with get a feel for whether it works or not: As for the implementation I'd say we'd need to find a different way given the way it affects the browser history. |
Just a note to say I've updated the OP to include the latest designs, and added a couple of tasks to the list. |
We're discussing a bit in #49597 (comment), but I'm not too sure about the "Manage" links in the title. It doesn't seem like a pattern that will scale to translations. Everything else looks good to me. |
I think the shortcut is useful as the page list in the panel is not exhaustive. Perhaps it can be a contextual item in the command palette (related: #50407)? What do you think @richtabor? |
I’m not quite following? |
Apologies. I was suggesting that "Manage pages" could be a contextual shortcut in the command palette, when you're viewing the Pages panel in the Site Editor. It would link to wp-admin page list. |
It looks like the main work here is done, the follow ups are either not strictly related (add new page modal) or further improvements. I'm going to close this. Let's make sure to open issues for things that are relevant and don't have issues open yet. |
🤔 This issue is closed? Really?I'm wondering because I tested Gutenberg 16.1.2 today, but saw no possibility to edit a page and template combined (as it was possible til until 15.9.1)
So where is that possibility now? |
Based on feedback it was very confusing for users to edit both template and page at the same time hence the split. I appreciate it's useful for theme authors to preview with real content though. #28466 looks like a good way to address that. |
Thx, had followed up there meanwhile. |
Visual
Tasks
The text was updated successfully, but these errors were encountered: