Add quick links header to the templates and pages site editor sidebars #50500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +39 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 02e253f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4935025829
|
|
I think we can tackle the visual details separately, hopefully in a single PR.
I agree the icons will be useful. Ideally it would be an option on the menu item component to include the icon. Also agree we don't need to handle that in this PR.
To push back on that a bit, when you have many items in the menu the quick links are not visible in the viewport, which kind of defeats the "quick" purpose. My preference would be for them to be stuck, just above the save dock. All that said, there is on-going discussion about the placement of these links in #50379. I suppose if they were to be made part of the save dock, that would change things quite a bit? So perhaps it's worth holding off on this one. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First small follow-up to #50463
Related to #44461
What?
This is just a small PR that adds "Quick links" header to the sidebar of both "templates" and "pages" in the site editor to clearly differentiate between the list of pages and templates and the "manage all" links. This is based on some of the mockups on the related issue.
Notes
I've noticed that in the mockups, there are three main differences with the current design: