Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Remove usage of Reakit #53278

Closed
9 tasks done
mirka opened this issue Aug 3, 2023 · 0 comments · Fixed by #58631
Closed
9 tasks done

Components: Remove usage of Reakit #53278

mirka opened this issue Aug 3, 2023 · 0 comments · Fixed by #58631
Assignees
Labels
Needs Dev Note Requires a developer note for a major WordPress release cycle [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@mirka
Copy link
Member

mirka commented Aug 3, 2023

What problem does this address?

Reakit does not explicitly support React 18, so it is causing peer dependency warnings.

Reakit has already been succeeded by Ariakit, so it will not receive any more updates.

What is your proposed solution?

Replace Reakit usage with Ariakit, or possibly other libraries like Radix UI.

Components remaining

Make sure we have sufficient test coverage of the existing components before we start a migration.

@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Aug 3, 2023
@mirka mirka added the [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. label Aug 11, 2023
@ciampo ciampo moved this to Todo in Andrew's onboarding Aug 30, 2023
@ciampo ciampo moved this from Todo to Up next in Andrew's onboarding Aug 30, 2023
@andrewhayward andrewhayward moved this from Up next to In Progress in Andrew's onboarding Sep 6, 2023
@andrewhayward andrewhayward moved this from In Progress to Paused in Andrew's onboarding Sep 7, 2023
@ciampo ciampo moved this from Paused to In Progress in Andrew's onboarding Sep 13, 2023
@ciampo ciampo added the Needs Dev Note Requires a developer note for a major WordPress release cycle label Nov 9, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Note Requires a developer note for a major WordPress release cycle [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants