Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Composite consumers from reakit to ariakit #55224

Closed
3 of 6 tasks
andrewhayward opened this issue Oct 10, 2023 · 2 comments
Closed
3 of 6 tasks

Migrate Composite consumers from reakit to ariakit #55224

andrewhayward opened this issue Oct 10, 2023 · 2 comments
Assignees
@andrewhayward
Labels
[Feature] Block Directory Related to the Block Directory, a repository of block plugins [Package] Block editor /packages/block-editor [Package] Components /packages/components [Package] Edit Site /packages/edit-site [Type] Enhancement A suggestion for improvement. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@andrewhayward
Copy link
Contributor

andrewhayward commented Oct 10, 2023 •
edited
Loading

What problem does this address?

As per #53278, we need to move away from reakit to use ariakit instead. #54225 started on migrating the Composite component, by adding the equivalent ariakit modules as a v2. This work needs to be completed by migrating all Composite consumers to use the v2 alternative.

What is your proposed solution?

We need to...

  • ...identify all Composite consumers across Gutenberg
  • ...iteratively refactor all usages of the reakit implementation.

When all consumers are migrated, we should then...

  • ...remove the reakit version of Composite
  • ...make the ariakit-based version standard
  • ...move all consumer away from the private API
  • ...remove the private API export
@andrewhayward andrewhayward added the [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. label Oct 10, 2023
@andrewhayward andrewhayward self-assigned this Oct 10, 2023
@andrewhayward andrewhayward added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Oct 10, 2023
@andrewhayward andrewhayward mentioned this issue Oct 10, 2023
Closed
9 tasks
@andrewhayward
Copy link
Contributor Author

andrewhayward commented Oct 10, 2023 •
edited
Loading

Composite consumers

block-directory

block-editor

edit-site

@andrewhayward andrewhayward moved this to In Progress in Andrew's onboarding Oct 10, 2023
@andrewhayward andrewhayward added [Package] Block editor /packages/block-editor [Package] Edit Site /packages/edit-site labels Oct 11, 2023
This was referenced Oct 11, 2023
Merged
Merged
@andrewhayward andrewhayward added the [Feature] Block Directory Related to the Block Directory, a repository of block plugins label Oct 12, 2023
This was referenced Oct 13, 2023
Merged
Closed
Merged
This was referenced Nov 14, 2023
Merged
Merged
Merged
Merged
This was referenced Nov 27, 2023
Closed
Closed
Merged
@mirka mirka mentioned this issue Jan 26, 2024
Merged
@andrewhayward
Copy link
Contributor Author

Closing with #58850 to track remaining work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewhayward andrewhayward

Labels
[Feature] Block Directory Related to the Block Directory, a repository of block plugins [Package] Block editor /packages/block-editor [Package] Components /packages/components [Package] Edit Site /packages/edit-site [Type] Enhancement A suggestion for improvement. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
WordPress Components
Status: Done 🎉
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewhayward