Migrating block editor BlockPatternsList component
#56210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes `__unstableComposite` imports from `@wordpress/components` - Adds private `Composite*` exports from `@wordpress/components` - Refactors `BlockPatternsList` and `BlockPattern` to use updated `Composite` components - Additionally renames list component to be consistent with codebase
andrewhayward
added
[Type] Task
andrewhayward
requested review from
SaxonF,
glendaviesnz,
ntsekouras and
a team
6 tasks
|
Size Change: +58 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8fa80a5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6958437822
|
andrewhayward
added
[Type] Code Quality
ciampo
reviewed
Nov 17, 2023
packages/block-editor/src/components/block-patterns-list/index.js
Outdated
Show resolved
Hide resolved
ciampo
approved these changes
Nov 22, 2023
packages/block-editor/src/components/block-patterns-list/index.js
Outdated
Show resolved
Hide resolved
See also #56442. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates
BlockPatternsListin@wordpress/block-editorto use the updatedCompositeimplementation from #54225.Why?
In #54225, an updated implementation of
Compositewas added to@wordpress/components. As per #55224, all consumers ofCompositeneed to migrate from the old version to the new version.How?
__unstableCompositeimports from@wordpress/componentsComposite*exports from@wordpress/componentsBlockPatternsListandBlockPatternto use updatedCompositecomponentsTesting Instructions
Testing Instructions for Keyboard