Migrating BlockPatternList to use updated Composite implementation
#55383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 16, 2023 13:14
- Removes `__unstableComposite` imports from `@wordpress/components` - Adds private `Composite*` exports from `@wordpress/components` - Refactors `BlockPatternList`/`BlockPattern` to use updated `Composite` components
andrewhayward
added
[Type] Task
andrewhayward
requested review from
ciampo,
chad1008,
ntsekouras and
brookewp
|
Size Change: +4.69 kB (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 249911b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6589529145
|
6 tasks
|
@diegohaz are you aware of any conflicts with Some tests are failing in this PR, after I moved from ...
// ...and if not, perform a global search.
if ( ! insertButton ) {
insertButton = await searchGlobalInserter( category, searchTerm );
}
// Throw an error if nothing was found.
if ( ! insertButton ) {
throw new Error(
`Couldn't find "${ searchTerm }" in the ${ category } category.`
);
}
// Insert found entity.
await insertButton.click();
^^^^^^^^^^^^^^^^^^^^^^^^^^^
...I know the node is present, because it's not throwing the error above. But it doesn't seem to actually call the If I slow the test down, and watch it run in a browser, it works fine. So I'm assuming it's some sort of timing issue again. puppeteer-without-delay.movpuppeteer-with-delay.mov |
I'm not aware of any problems with Puppeteer. Are you certain that |
Sigh. I thought I was certain, but turns out that no, it was not resolving to the correct one. The Thanks for the input @diegohaz! |
Is there any specific reason to change the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates
BlockPatternListin@wordpress/block-editorto use the updatedCompositeimplementation from #54225.As an aside to maintain consistency/integrity,
BlockPatternListis renamed toBlockPatternsListso as to match both the file name and usage elsewhere.Why?
In #54225, an updated implementation of
Compositewas added to@wordpress/components. As per #55224, all consumers ofCompositeneed to migrate from the old version to the new version.How?
__unstableCompositeimports from@wordpress/componentsComposite*exports from@wordpress/componentsBlockPatternList/BlockPatternto use updatedCompositecomponentsTesting Instructions
Note
To come...
Testing Instructions for Keyboard
Note
To come...