Migrating DownloadableBlocksList to use updated Composite implementation
#55272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes `__unstableComposite` imports from `@wordpress/components` - Adds private `Composite*` exports from `@wordpress/components` - Refactors `DownloadableBlocksList` and `DownloadableBlockListItem` to use updated `Composite` components
andrewhayward
added
[Type] Task
andrewhayward
requested review from
ryelle,
ciampo,
chad1008,
rafaelgallani and
brookewp
6 tasks
andrewhayward
changed the title
DownloadableBlocksListDownloadableBlocksList to use updated Composite implementation
|
Size Change: +1.66 kB (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 4f8052b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6484967006
|
ciampo
approved these changes
Oct 11, 2023
packages/block-directory/src/components/downloadable-block-list-item/index.js
Outdated
Show resolved
Hide resolved
tyxla
approved these changes
Oct 11, 2023
packages/block-directory/src/components/downloadable-block-list-item/index.js
Outdated
Show resolved
Hide resolved
bph
added
the
Needs Dev Note
Added |
|
I think that a better issue for the |
32 tasks
mirka
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates
AddCustomTemplateModalContentandDownloadableBlockListItemin@wordpress/block-directoryto use the updatedCompositeimplementation from #54225.Why?
In #54225, an updated implementation of
Compositewas added to@wordpress/components. As per #55224, all consumers ofCompositeneed to migrate from the old version to the new version.How?
__unstableCompositeimports from@wordpress/componentsComposite*exports from@wordpress/componentsDownloadableBlocksListandDownloadableBlockListItemto use updatedCompositecomponentsTesting Instructions
listbox, the behaviour of which should be no different than beforeTesting Instructions for Keyboard
The
listboxcontaining the installable blocks should act as a single tab stop, with arrow keys used to navigate between items.