Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] callbacks should run whenever the specified event is dispatched #58398

Closed
github-actions bot opened this issue Jan 29, 2024 · 2 comments · Fixed by #58642 or #58668
Closed

[Flaky Test] callbacks should run whenever the specified event is dispatched #58398

github-actions bot opened this issue Jan 29, 2024 · 2 comments · Fixed by #58642 or #58668
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Jan 29, 2024

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

callbacks should run whenever the specified event is dispatched

Test path

/test/e2e/specs/interactivity/directive-on-document.spec.ts

Errors

[2024-01-29T16:52:25.560Z] Test passed after 1 failed attempt on trunk.
[2024-01-30T11:32:44.216Z] Test passed after 1 failed attempt on update/dataviews-folder-structure.
[2024-01-30T12:49:37.529Z] Test passed after 1 failed attempt on update/change-patterns-overrides-source-name.
[2024-01-30T15:17:29.467Z] Test passed after 1 failed attempt on update/document-php-return-anti-pattern.
[2024-01-30T21:18:01.508Z] Test passed after 1 failed attempt on move-shadows-to-border-panel.
[2024-01-30T22:10:49.695Z] Test passed after 1 failed attempt on try/forbid-calling-disallowed-functions-sniff.
[2024-01-31T05:12:01.707Z] Test passed after 1 failed attempt on try/reduce-global-styles-specificity.
[2024-01-31T08:51:52.226Z] Test passed after 1 failed attempt on fix/translators-comments-wp-date-setsettings-compat-file.
[2024-01-31T09:48:18.959Z] Test passed after 1 failed attempt on revert/patch-format-for-pattern-overrides.
[2024-01-31T10:39:33.933Z] Test passed after 1 failed attempt on fix/update-lightbox-label-editor.
[2024-01-31T11:11:57.926Z] Test passed after 2 failed attempts on fix/refactor-pre-publish-tags-to-use-function-components.
[2024-01-31T11:12:21.604Z] Test passed after 1 failed attempt on try/preview-shadow-dom.
[2024-01-31T11:14:31.600Z] Test passed after 1 failed attempt on trunk.
[2024-01-31T12:55:58.332Z] Test passed after 1 failed attempt on add/data-wp-each-server-directive-processor.
[2024-02-01T00:43:21.469Z] Test passed after 1 failed attempt on try/reduce-global-styles-specificity.
[2024-02-03T09:29:45.379Z] Test passed after 1 failed attempt on redesign/dataviews-filters.
[2024-02-05T00:09:32.123Z] Test passed after 1 failed attempt on fix/dragging-to-template-parts-for-block-inserter-and-drag-from-desktop.
[2024-02-05T08:29:06.665Z] Test passed after 1 failed attempt on add/pattern-overrides-links.
[2024-02-05T11:59:13.496Z] Test passed after 1 failed attempt on update/move-set-allowed-mime-types.
Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected)

Locator: getByTestId('counter')
Expected string: "1"
Received string: "0"
Call log:
  - expect.toHaveText with timeout 5000ms
  - waiting for getByTestId('counter')
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p>
  -   unexpected value "0"
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p>
  -   unexpected value "0"
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p>
  -   unexpected value "0"
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p>
  -   unexpected value "0"
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p>
  -   unexpected value "0"
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p>
  -   unexpected value "0"
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p>
  -   unexpected value "0"
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p>
  -   unexpected value "0"
  -   locator resolved to <p data-testid="counter" data-wp-text="state.counte…>0</p>
  -   unexpected value "0"

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/interactivity/directive-on-document.spec.ts:27:27
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Jan 29, 2024
github-actions bot referenced this issue Jan 31, 2024
#58490)

* Update label; update active status when lightbox is enabled

* Update e2e with label change

---------

Co-authored-by: Ricardo Artemio Morales <ric.morales22@gmail.com>
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 3, 2024
@luisherranz
Copy link
Member

Attempt to fix this:

@luisherranz
Copy link
Member

Oh, this is data-wp-on-document, I fixed data-wp-on-window 🤦‍♂️

@c4rl0sbr4v0 can you apply the fix of #58642 to data-wp-on-document as well to see if we finally get rid of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
2 participants