Move getAllowedMimeTypes to FontUtils

[youknowriad]

What?

This moves this utility function to a font utils class per feedback on the Core backport PR as it's not something specific to a collection or the font library.

No functional change here.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: youknowriad, get_dave.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.5/fonts/class-wp-font-library.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-font-utils.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-rest-font-faces-controller.php
❔ phpunit/tests/fonts/font-library/fontLibraryHooks.php

[getdave]

This change feels entirely logical. These are util type functions as indicated by their static keyword in the original class.

The utils class is a more natural fit.

[youknowriad]

This test is useless to me, it just repeats the same logic of the function IMO

[github-actions]

Flaky tests detected in 584a4e8.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7783860054
📝 Reported issues:

• [Flaky Test] callbacks should run whenever the specified event is dispatched #58398 in /test/e2e/specs/interactivity/directive-on-document.spec.ts