Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Block doesn't work when inserting YouTube URL #6824

Closed
maddisondesigns opened this issue May 18, 2018 · 11 comments
Closed

Video Block doesn't work when inserting YouTube URL #6824

maddisondesigns opened this issue May 18, 2018 · 11 comments
Labels
[Feature] Block Transforms Block transforms from one block to another [Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@maddisondesigns
Copy link

Describe the bug
I wanted to insert a video on my page. The Video Block prompts me to "Enter URL of video here...", so I pasted in the YouTube URL for a vid. After saving the page and checking the front-end, the video didn't appear. I then went back to the editor and noticed the Use URL button so I clicked that but the block just produced an error.

People are going to expect to be able to be able to insert YouTube vids into a block that is specifically called a Video Block.

To Reproduce
Steps to reproduce the behavior:

  1. Insert video block
  2. Enter YouTube URL where it says "Enter URL of video here..."
  3. Click save and view site (no video shows)
  4. Go back to Editor and click Use URL button (view error)

Expected behavior
I should be able to paste YouTube/Vimeo URLS into a block that's called a Video Block

Screenshots
gutenberg_videoblock

macOS Sierra 10.12.1 (16B2659)
Firefox Quantum 60.0 (64-bit)
WordPress 4.9.6
Gutenberg 2.8.0

@danielbachhuber danielbachhuber added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks labels May 18, 2018
@danielbachhuber danielbachhuber added this to the WordPress 5.0 milestone May 18, 2018
@danielbachhuber
Copy link
Member

People are going to expect to be able to be able to insert YouTube vids into a block that is specifically called a Video Block.

This seems like a reasonable assumption to me.

@danielbachhuber
Copy link
Member

Related #5241

@mtias mtias added the [Feature] Block Transforms Block transforms from one block to another label Jul 19, 2018
@Soean Soean mentioned this issue Jul 30, 2018
5 tasks
@sarahmonster
Copy link
Member

People are going to expect to be able to be able to insert YouTube vids into a block that is specifically called a Video Block.

+1 from me! It's literally the first thing I tried to do with it whilst testing in #8299.

@designsimply
Copy link
Member

+1 here too! Noting feedback from #5671 which I closed as a duplicate:

As a user, I shouldn't have to know that there are separate youtube, vimeo, and native video blocks. All I want to do is put a video in my post.

@karmatosed
Copy link
Member

I am going to suggest a really simple flow that may not be so easy to implement but I think means we don't need to do any design changes.

2018-11-02 at 09 13

Where we have this above, could we just if someone copies in a YouTube URL, transform to the right block?

@karmatosed karmatosed added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Nov 2, 2018
@notnownikki
Copy link
Member

Where we have this above, could we just if someone copies in a YouTube URL, transform to the right block?

Yes!

The refactor in #10958 exposes some of the embed block's URL->block resolution code, so the video block would be able to use that to resolve the URL to an appropriate embed block.

@notnownikki
Copy link
Member

Hey peeps, how does this look? It switches to an embed block if you use a youtube URL with a video block.

video-to-embed

@notnownikki
Copy link
Member

Fix up for review at #11410

@mtias
Copy link
Member

mtias commented Nov 4, 2018

Thank you both @maddisondesigns for bringing this up and @notnownikki for making the improvement. It's a nice and seemingly obvious UX addition.

@notnownikki
Copy link
Member

notnownikki commented Nov 4, 2018 via email

@cpi83
Copy link

cpi83 commented Apr 10, 2021

i have the same issue. The console says cross origin read blocking. How can this be fixed?

@tofumatt tofumatt removed their assignment Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Transforms Block transforms from one block to another [Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

10 participants