Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch video block to embed if the URL should be handled by embed #11410

Merged
merged 1 commit into from
Nov 4, 2018
Merged

Switch video block to embed if the URL should be handled by embed #11410

merged 1 commit into from
Nov 4, 2018

Conversation

notnownikki
Copy link
Member

Description

Fixes: #6824

If a YouTube URL is used with a video block, it should switch to an embed block.

How has this been tested?

Try to add a YouTube video to a post using a Video block.

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@Soean Soean added the [Block] Video Affects the Video Block label Nov 2, 2018
@notnownikki notnownikki requested review from karmatosed, mtias and a team November 2, 2018 14:40
@notnownikki notnownikki mentioned this pull request Nov 2, 2018
Closed
@mtias mtias added this to the 4.3 milestone Nov 2, 2018
Soean
Soean approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

  • Tested with Vimeo and Youtube
  • URLs to files like .mp4 still work
  • Uploading and Media Library also work

@mtias mtias added the [Block] Embed Affects the Embed Block label Nov 2, 2018
@Soean Soean mentioned this pull request Nov 2, 2018
Closed
karmatosed
karmatosed approved these changes Nov 4, 2018
View reviewed changes
Copy link
Member

@karmatosed karmatosed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected and is awesome thanks @notnownikki!

@notnownikki notnownikki merged commit 723be1d into master Nov 4, 2018
@notnownikki notnownikki deleted the update/video-to-embed branch November 4, 2018 17:26
@Soean Soean mentioned this pull request Nov 4, 2018
Merged
@Soean Soean mentioned this pull request Nov 15, 2018
Closed
@jd-alexander jd-alexander mentioned this pull request Sep 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karmatosed karmatosed karmatosed approved these changes

@Soean Soean Soean approved these changes

@mtias mtias Awaiting requested review from mtias

Assignees
No one assigned
Labels
[Block] Embed Affects the Embed Block [Block] Video Affects the Video Block
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@notnownikki @karmatosed @Soean @mtias