Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use better help text for ALT text input #11052

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Conversation

sarahmonster
Copy link
Member

This is just a wee tweak to the description for the accessibility text input, to clarify its purpose and ideally help users build content that's more accessible. I considered using a link for more information but I'm not sure of a good resource to link to that would be evergreen, so I decided to leave it as-is.

Before:
screenshot 2018-10-25 11 30 52

After:
screenshot 2018-10-25 11 31 13

We may also want to include text that indicates to leave the text blank if the image isn't a key part of content, but I've opted for the phrasing suggested in #8391.

Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a lot better and more instructive. 🚢

@tofumatt tofumatt added this to the 4.2 milestone Oct 25, 2018
@tofumatt tofumatt merged commit 3c81345 into master Oct 25, 2018
@tofumatt tofumatt deleted the fix/8391-clarify-alt-text branch October 25, 2018 13:19
antpb pushed a commit to antpb/gutenberg that referenced this pull request Oct 26, 2018
daniloercoli added a commit that referenced this pull request Oct 26, 2018
…rnmobile/merge-blocks-on-backspace

* 'master' of https://github.com/WordPress/gutenberg:
  Do not add isDirty prop to DOM (#11093)
  Format API (#10209)
  Remove 4.2 deprecated features (#10952)
  Update `@wordpress/hooks` README to include namespace mention (#11061)
  Feature: save lock control via actions (#10649)
  Fix usage of `preg_quote()` (#10998)
  Update plugin version to 4.1.1 (#11078)
  Improve preloading request code (#11007)
  Fix dynamic blocks not rendering in the frontend (#11050)
  Media & Text: Fixing vertical alignment of the image (#11025)
  Date: Mark getSettings as experimental (#10636)
  Improve handling of centered 1-col galleries with small images (#11040)
  Use better help text for ALT text input; fixes #8391. (#11052)

# Conflicts:
#	packages/editor/src/components/rich-text/index.native.js
@mtias mtias added [Type] Enhancement A suggestion for improvement. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants