Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not add isDirty prop to DOM #11093

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Do not add isDirty prop to DOM #11093

merged 1 commit into from
Oct 26, 2018

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Oct 26, 2018 •
edited
Loading

Fixes #10875

Having isDirty prop in the DOM was making React unhappy.

@oandregal oandregal self-assigned this Oct 26, 2018
@oandregal oandregal added this to the 4.2 milestone Oct 26, 2018
@oandregal oandregal mentioned this pull request Oct 26, 2018
Closed
@gziolo
Copy link
Member

gziolo commented Oct 26, 2018

Apparently, React elements don't want to be recognized as dirty 😄

@oandregal oandregal merged commit cb22c14 into master Oct 26, 2018
@oandregal oandregal deleted the remove/isdirty-prop-publish-panel branch October 26, 2018 09:04
daniloercoli added a commit that referenced this pull request Oct 26, 2018
@daniloercoli
Merge branch 'master' of https://github.com/WordPress/gutenberg into …
7659051 
…rnmobile/merge-blocks-on-backspace

* 'master' of https://github.com/WordPress/gutenberg:
  Do not add isDirty prop to DOM (#11093)
  Format API (#10209)
  Remove 4.2 deprecated features (#10952)
  Update `@wordpress/hooks` README to include namespace mention (#11061)
  Feature: save lock control via actions (#10649)
  Fix usage of `preg_quote()` (#10998)
  Update plugin version to 4.1.1 (#11078)
  Improve preloading request code (#11007)
  Fix dynamic blocks not rendering in the frontend (#11050)
  Media & Text: Fixing vertical alignment of the image (#11025)
  Date: Mark getSettings as experimental (#10636)
  Improve handling of centered 1-col galleries with small images (#11040)
  Use better help text for ALT text input; fixes #8391. (#11052)

# Conflicts:
#	packages/editor/src/components/rich-text/index.native.js
@mtias mtias added the [Type] Bug An existing feature does not function as intended label Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@afercia afercia Awaiting requested review from afercia

Assignees

@oandregal oandregal

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@oandregal @gziolo @mtias