Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make notices push down content #13614

Merged
merged 3 commits into from
Feb 14, 2019
Merged

Make notices push down content #13614

merged 3 commits into from
Feb 14, 2019

Commits on Feb 12, 2019

  1. Make notices push down content 

    This PR restores the good stuff from #12301. That is: it allows notices to push down content. Dismissible notices are sticky at the top, non-dismisible notices scroll out of view.

This is mostly an exact copy of the other PR, but fresh. The behavior has a number of benefits:

- If you have multiple non-dismissible notices, you can still actually use the editor.
- Notices no longer cover the scrollbar.
- Notices no longer cover the permalink interface.
- Notices now only cover content if you do not dismiss the notices.
    Joen Asmussen committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    33ddecf View commit details
    Browse the repository at this point in the history

  2. Address top toolbar issues.

    Joen Asmussen committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    09e28e6 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. Remove the overly specific is-pinned.

    @jasmussen
    jasmussen committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    b1c72b6 View commit details
    Browse the repository at this point in the history