Test transform from media to embed blocks #13997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Task
draganescu
requested review from
aduth,
ajitbohra,
gziolo,
nerrad,
ntwb,
talldan and
youknowriad
as code owners
aduth
reviewed
Feb 21, 2019
|
I added the mocking of audio and image test URLs and also used the video URL which was already mocked. |
gziolo
added
the
[Type] Automated Testing
draganescu
force-pushed
the
add/tests-for-transform-embeddable-urls
branch
from
088083c
to
ad23c70
Compare
|
The undo tests seem to fail for everyone on travis, for some they work on local. Ran locally they fail because of a timeout. Interestingly, setting the timeout to be higher using both Running in playback mode results in the same timeout, although visual inspection shows undo does work! |
|
Yes, the Undo tests are very unstable at the moment. I'm hoping this is improved with #14108. |
noisysocks
requested changes
Mar 5, 2019
…s in to embeds when embeddable URLs are provided
draganescu
force-pushed
the
add/tests-for-transform-embeddable-urls
branch
from
ad23c70
to
2cce5c2
Compare
This was referenced Sep 13, 2024
This was referenced Sep 14, 2024
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11901
Added e2e tests to test the transform of audio, video and image blocks in to embeds when embeddable URLs are provided
Description
Added e2e tests to test the transform of audio, video and image blocks in to embeds when embeddable URLs are provided
Checklist: