Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor core blocks to have deprecated extracted to their own files (p.1) #14979

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Apr 14, 2019

Description

Part of aligning block library to Block Registration API RFC #13693.

It's all about moving deprecated fields to their own file to follow the proposal drafted in RFC.

Updated blocks:

  • Button
  • Cover

How has this been tested?

npm test
npm run test-e2e

Manually tested whether all blocks load as before.

@gziolo gziolo self-assigned this Apr 14, 2019
@gziolo gziolo added [Package] Block library /packages/block-library [Feature] Block Directory Related to the Block Directory, a repository of block plugins labels Apr 14, 2019
Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restarted a failing e2e test.

@gziolo gziolo merged commit 0ccb047 into master Apr 18, 2019
@gziolo gziolo deleted the update/block-extract-deprecated-1 branch April 18, 2019 06:35
@gziolo gziolo added this to the 5.6 (Gutenberg) milestone Apr 18, 2019
daniloercoli added a commit that referenced this pull request Apr 18, 2019
…rnmobile/887-History-stack-is-not-empty-on-a-fresh-start-of-the-editor

* 'master' of https://github.com/WordPress/gutenberg:
  Reset embed mocks on every request, stop request to instagram (#15046)
  Refactor core blocks to have save and transforms in their own files (part 2) (#14899)
  Fix pullquote import (#15036)
  Refactor core blocks to have save and transforms in their own files (part 4) (#14903)
  Refactor core blocks to have save and transforms in their own files (part 3) (#14902)
  Refactor core blocks to have deprecated extracted to their ownf files (p.1) (#14979)
  Test transform from media to embed blocks (#13997)
  If a more recent revision/autosave exists, store its state on editor setup (#7945)
  chore(release): publish
@gziolo gziolo added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Directory Related to the Block Directory, a repository of block plugins [Package] Block library /packages/block-library [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants