Add wpDataSelect WordPress end 2 end test util #15052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
aduth,
ajitbohra,
gziolo,
nerrad,
ntwb and
youknowriad
as code owners
jorgefilipecosta
added
the
[Type] Automated Testing
gziolo
approved these changes
Apr 19, 2019
There was a problem hiding this comment.
I personally like this util a lot. In fact, we might also want to deprecate all the existing wrappers which seem to be no longer necessary and bring only another level of abstraction 🤷♂️
@aduth and @youknowriad, what do you think about that?
Co-Authored-By: jorgefilipecosta <jorge.costa@developer.pt>
jorgefilipecosta
force-pushed
the
add/wpDataSelect-end-2-end-test-util
branch
from
f3d06e8 to
cf90445
Compare
daniloercoli
added a commit
that referenced
this pull request
Apr 23, 2019
…rnmobile/887-History-stack-is-not-empty-on-a-fresh-start-of-the-editor * 'master' of https://github.com/WordPress/gutenberg: 'string' misspelled as 'srting' (#15118) [Mobile] Improving accessibility on Post title (#15106) Fix 13776: Format is already registered to handle class name (#15072) Add wpDataSelect WordPress end 2 end test util (#15052) Block Editor: move selection state from RichText to the store (#14640) chore: Fix: Lint error that makes unit tests (and CI tests) fail. (#15073) Set ownProps.onFocus when context.onFocus is undefined. (#15069)
This was referenced Apr 29, 2019
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This a follow up on a suggestion by @gziolo to have a simple utility that allows us to easily query the WordPress data module.
How has this been tested?
Verify the end 2 end tests pass.