[Mobile] Improving accessibility on Post title #15106
Conversation
pinarol
added
[Focus] Accessibility (a11y)
| <View | ||
| style={ [ styles.titleContainer, borderStyle, { borderColor } ] } | ||
| accessible={ ! this.state.isSelected } | ||
| accessibilityLabel={ __( 'Post title' ) + '. ' + ( isEmpty( title ) ? __( 'Empty' ) : title ) } |
There was a problem hiding this comment.
Just a quick note about this:
Although most languages use a period (.) to end a sentence, some don't, and we might think that it would be more correct to use sprintf in this case to concatenate the 2 sentences.
sprintf( __( 'Post title. %s' ), isEmpty( title ) ? __( 'Empty' ) : title )
However I don't think it's worth it at this point. it's not very clear for translators what the Post title. %s string means (even with a comment). Moreover Post title will probably be reused at other places so it makes more sense to translate that only.
Lastly, this sentence is built to be heard not read by the user.
There was a problem hiding this comment.
Updating this according to what we discussed
There was a problem hiding this comment.
Good catch! We can refer to this one for the future accessibility labels
|
Tested on iOS, this worked well 👍. I noticed it says "actions available" at the end, not sure why? |
There was a problem hiding this comment.
Tested via wordpress-mobile/gutenberg-mobile#916 (review) ✅
@Tug , for the Android issues we created a new ticket. There seems to be an issue with the Android side of the Aztec Wrapper: wordpress-mobile/gutenberg-mobile#918
Actions Available: It's good to let the user know that something will happen if they double tap on it (this element has an action).
It's also good practice to mark these elements as button (as they are tappable).
Let's 
after @Tug 's ✅ :)
|
hey @Tug are you ok with the last changes? |
|
Yes! let's 🚢 !! |
…rnmobile/887-History-stack-is-not-empty-on-a-fresh-start-of-the-editor * 'master' of https://github.com/WordPress/gutenberg: 'string' misspelled as 'srting' (#15118) [Mobile] Improving accessibility on Post title (#15106) Fix 13776: Format is already registered to handle class name (#15072) Add wpDataSelect WordPress end 2 end test util (#15052) Block Editor: move selection state from RichText to the store (#14640) chore: Fix: Lint error that makes unit tests (and CI tests) fail. (#15073) Set ownProps.onFocus when context.onFocus is undefined. (#15069)
* Add accessibilityLabel to post title * Update accessibilityLabel * Update accessibilityLabel * Remove unnecessary line * Import sprintf from i18n
Description
This PR improves accessibility on the Post title.
Fixes wordpress-mobile/gutenberg-mobile#912
To test:
Please refer to the gutenberg-mobile side PR.
Checklist: