Testing: Update end-to-end tests to use Escape press to activate block toolbar #15063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Enhancement
aduth
requested review from
ajitbohra,
gziolo,
nerrad,
ntwb,
talldan and
youknowriad
as code owners
youknowriad
reviewed
Apr 18, 2019
| @@ -34,8 +34,8 @@ describe( 'block deletion -', () => { | |||
| // The blocks can't be empty to trigger the toolbar | |||
| await page.keyboard.type( 'Paragraph to remove' ); | |||
|
|
|||
| // Move the mouse to show the block toolbar | |||
| await page.mouse.move( 200, 300, { steps: 10 } ); | |||
There was a problem hiding this comment.
Last time I tried this change, the mouse moving was still more reliable but I don't remember the details, maybe it's better this time :)
There was a problem hiding this comment.
Last time I tried this change, the mouse moving was still more reliable but I don't remember the details, maybe it's better this time :)
I can't imagine why that would be 🤷♂️ The tests are passing here at least. Let me know if you can find a reference to the issues you'd seen previously.
There was a problem hiding this comment.
I don't remember precisely and I agree it's better using the keyboard shortcuts. The intent is clearer.
youknowriad
approved these changes
Apr 18, 2019
daniloercoli
added a commit
that referenced
this pull request
Apr 19, 2019
…rnmobile/887-History-stack-is-not-empty-on-a-fresh-start-of-the-editor * 'master' of https://github.com/WordPress/gutenberg: Avoid running hasMetaBoxes on each subscribe (#15041) Avoid passing down isFirst and isLast props (#15043) Add "Roadmap" document with an overview of projects in consideration. (#14907) Testing: Update tests to use Escape press to activate block toolbar (#15063) Testing: Skip unreliable end-to-end tests (#15059)
This was referenced Apr 29, 2019
This was referenced Sep 11, 2024
[Snyk] Upgrade @wordpress/postcss-plugins-preset from 1.6.0 to 5.6.0
WontonSam/woocommerce-admin#263
Open
This was referenced Sep 13, 2024
This was referenced Sep 14, 2024
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to replace use of a "mouse wiggle" interaction in end-to-end tests with a simpler, direct keyboard interaction. There was originally no way to activate the block toolbar using a keyboard, so an arbitrary mouse move interaction was implemented in tests to activate the toolbar. This was later found to be generally unreliable without a
stepsproperty to slow the interaction across many distinct steps.Since it's now possible to activate the toolbar using the keyboard, these changes are proposed as an improvement to:
Testing Instructions:
Ensure end-to-end tests pass: