Avoid running hasMetaBoxes on each subscribe #15041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Performance
Is there a sense of why it has a noted impact? Curious if there's something problematic of the underlying selector. I'd probably agree if we can be certain it's initialized once, it would be fine to move it out of the |
aduth
approved these changes
Apr 18, 2019
Co-Authored-By: youknowriad <benguella@gmail.com>
daniloercoli
added a commit
that referenced
this pull request
Apr 19, 2019
…rnmobile/887-History-stack-is-not-empty-on-a-fresh-start-of-the-editor * 'master' of https://github.com/WordPress/gutenberg: Avoid running hasMetaBoxes on each subscribe (#15041) Avoid passing down isFirst and isLast props (#15043) Add "Roadmap" document with an overview of projects in consideration. (#14907) Testing: Update tests to use Escape press to activate block toolbar (#15063) Testing: Skip unreliable end-to-end tests (#15059)
|
Looks like this was merged with failing tests. |
|
yep sorry about that missed it, I included the suggestion above and thought was harmless cause it was just a comment :) |
This was referenced Apr 29, 2019
This was referenced Oct 20, 2022
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While monitoring the typing performance, I noticed that in the duraction of the key press event (53ms), 2 or 3ms is spent on calling
hasMetaboxesselector. In this PR, I'm managing to tweak the side effect a little bit to avoid calling this selector on each subscribe.While if we're trying to be pure, we should call the selector on each subscribe, in this particular use-cases where this is a legacy API that is only initialized at rendering, I think it's fine to optimize this way.