Metaboxes save: perform hasMetaBoxes check on every save #45145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: +119 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Oct 20, 2022
| const shouldTriggerMetaboxesSave = | ||
| hasMetaBoxes && |
There was a problem hiding this comment.
Can we keep the call to select.hasMetaBoxes() here that way a single boolean is enough for the check later?
There was a problem hiding this comment.
Like the change in 5c4e4c7? Done!
Mamaduka
added
[Type] Bug
youknowriad
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44716 by kind of reverting the optimization in #15041. The assumption about metaboxes being initialized only on rendering was wrong: folks add new metaboxes dynamically.
The patched code is still optimized because we call
select.hasMetaBoxes()only after detecting there is a "save finished" event, which is quite rate, the selector is not called on every registry state update like it was before #15041.