Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve accessibility on missing block #15457

Merged
merged 5 commits into from
May 10, 2019
Merged

Improve accessibility on missing block #15457

merged 5 commits into from
May 10, 2019

Conversation

koke
Copy link
Contributor

@koke koke commented May 6, 2019

@koke koke requested a review from etoledom May 6, 2019 11:34
@koke koke added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels May 6, 2019
etoledom
etoledom reviewed May 7, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @koke for improving Accessibility 🎉

I added a couple of comments, but it's working great!

packages/block-library/src/missing/edit.native.js Outdated Show resolved Hide resolved
packages/block-library/src/missing/edit.native.js Outdated Show resolved Hide resolved
etoledom and others added 2 commits May 7, 2019 09:25
@etoledom @koke
Update packages/block-library/src/missing/edit.native.js
3b9fcf8 
Co-Authored-By: koke <jbernal@gmail.com>
@etoledom @koke
Remove unnecessary dot for accessibility label
2887348 
Co-Authored-By: koke <jbernal@gmail.com>
etoledom
etoledom approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update!
Feel free to :shipit: when ✅ from CI

@koke koke merged commit 94d48e0 into master May 10, 2019
@koke koke deleted the rnmobile/a11y-unsupported branch May 10, 2019 11:05
@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
5.7 (Gutenberg)
Development

Successfully merging this pull request may close these issues.

Improve screen reader support for Unsupported Block
3 participants
@koke @etoledom @youknowriad