Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve accessibility on missing block #15457

Merged
merged 5 commits into from
May 10, 2019
Merged

Improve accessibility on missing block #15457

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3982ac2
Improve accessibility on missing block
koke May 6, 2019
3b9fcf8
Update packages/block-library/src/missing/edit.native.js
etoledom May 7, 2019
2887348
Remove unnecessary dot for accessibility label
etoledom May 7, 2019
e98052d
Merge branch 'master' into rnmobile/a11y-unsupported
koke May 7, 2019
b106145
Merge branch 'master' into rnmobile/a11y-unsupported
koke May 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions packages/block-library/src/missing/edit.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { Icon } from '@wordpress/components';
import { coreBlocks } from '@wordpress/block-library';
import { normalizeIconObject } from '@wordpress/blocks';
import { Component } from '@wordpress/element';
import { __ } from '@wordpress/i18n';
import { __, sprintf } from '@wordpress/i18n';

/**
* Internal dependencies
Expand All @@ -25,7 +25,20 @@ export default class UnsupportedBlockEdit extends Component {
const icon = blockType ? normalizeIconObject( blockType.settings.icon ) : 'admin-plugins';

return (
<View style={ styles.unsupportedBlock }>
<View style={ styles.unsupportedBlock }
accessible={ true }
accessibilityLabel={
blockType ?
sprintf(
/* translators: accessibility text. %s: unsupported block type. */
__( 'Unsupported block: %s.' ),
koke marked this conversation as resolved.
Show resolved Hide resolved
title
) :
/* translators: accessibility text. */
__( 'Unsupported block.' )
koke marked this conversation as resolved.
Show resolved Hide resolved
}
onAccessibilityTap={ this.props.onFocus }
>
<Icon className="unsupported-icon" icon={ icon && icon.src ? icon.src : icon } />
<Text style={ styles.unsupportedBlockMessage }>{ title }</Text>
</View>
Expand Down