Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toolbar bottom inset for iPhone X devices #16961

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Fix toolbar bottom inset for iPhone X devices #16961

merged 1 commit into from
Aug 8, 2019

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Aug 8, 2019 •
edited
Loading

Description

Addresses #16677 (comment)

How has this been tested?

Tested with Gutenberg mobile PR wordpress-mobile/gutenberg-mobile#1273

Types of changes

Layout changes for native mobile

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@Tug Tug added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Aug 8, 2019
@Tug Tug added this to the Future milestone Aug 8, 2019
@Tug Tug requested a review from etoledom August 8, 2019 09:59
@Tug Tug self-assigned this Aug 8, 2019
etoledom
etoledom approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 🎉

Thank you @Tug for taking care of this!

@Tug Tug merged commit ea6f2d9 into master Aug 8, 2019
@Tug Tug deleted the rnmobile/fix/toolbar-bottom-inset branch August 8, 2019 10:58
@youknowriad youknowriad modified the milestones: Future, Gutenberg 6.3 Aug 9, 2019
gziolo pushed a commit that referenced this pull request Aug 29, 2019
@Tug @gziolo
Fix toolbar bottom inset for iPhone X devices (#16961)
746c812
gziolo pushed a commit that referenced this pull request Aug 29, 2019
@Tug @gziolo
Fix toolbar bottom inset for iPhone X devices (#16961)
9277a9e
This was referenced Aug 1, 2024
Open
Open
Open
@snyk-io snyk-io bot mentioned this pull request Aug 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

Assignees

@Tug Tug

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Tug @etoledom @youknowriad